fix(javascript): clean up failed input binding

Author: chaokunyang

javascript/packages/core/lib/fory.ts

@@ -179,8 +179,8 @@ export default class Fory {
 
   deserialize<T = any>(bytes: Uint8Array, serializer: Serializer = this.anySerializer): T | null {
     this.registrationFrozen = true;
-    this.readContext.reset(bytes);
     try {
+      this.readContext.reset(bytes);
       const reader = this.readContext.reader;
       const bitmap = reader.readUint8();
       if (bitmap !== ConfigFlags.isCrossLanguageFlag) {
@@ -243,8 +243,8 @@ export default class Fory {
     const rootHeader = ConfigFlags.isCrossLanguageFlag;
     rootDeserializer = (bytes: Uint8Array) => {
       this.registrationFrozen = true;
-      readContext.reset(bytes);
       try {
+        readContext.reset(bytes);
         const bitmap = reader.readUint8();
         if (bitmap !== rootHeader) {
           this.throwInvalidRootHeader(bitmap);

javascript/test/rootCleanup.test.ts

@@ -91,6 +91,30 @@ describe.each([
 
     expect(readContext.typeMetaCache.get(headerHash)).toBe(typeMeta);
   });
+
+  test("clears retained state when input binding fails", () => {
+    const fory = new Fory({ compatible: true, ref: true });
+    const registered = fory.register(Type.struct(7615, {}));
+    const readContext = (fory as any).readContext;
+    const typeMeta = TypeMeta.fromTypeInfo(Type.struct(7616, {}));
+
+    registered.serializer.readRef = () => {
+      readContext.refReader.reference({});
+      populateLogicalTables(readContext, typeMeta);
+      return 7;
+    };
+    expect(invoke(fory, registered, new Uint8Array([1]))).toBe(7);
+
+    const invalidInput = new Uint8Array([1]);
+    Object.defineProperty(invalidInput, "buffer", {
+      get() {
+        throw new Error("input binding failed");
+      },
+    });
+    expect(() => invoke(fory, registered, invalidInput)).toThrow("input binding failed");
+    expect(readContext.reader.platformBuffer).toHaveLength(0);
+    expectRootStateCleared(readContext);
+  });
 });
 
 test("restores root write state after failure", () => {