From 61862581c8acdee340094426bbcfb9b0d13e0b02 Mon Sep 17 00:00:00 2001 From: William Lo Date: Thu, 31 Oct 2024 12:07:14 -0400 Subject: [PATCH 1/2] test --- gradle/scripts/globalDependencies.gradle | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/gradle/scripts/globalDependencies.gradle b/gradle/scripts/globalDependencies.gradle index 0084f1c94b9..feaa68a549f 100644 --- a/gradle/scripts/globalDependencies.gradle +++ b/gradle/scripts/globalDependencies.gradle @@ -14,10 +14,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ - -import javax.tools.ToolProvider - - subprojects { plugins.withType(JavaPlugin) { configurations { @@ -45,7 +41,7 @@ subprojects { customTestCompile externalDependency.slf4jToLog4j // Required to add JDK's tool jar, which is required to run byteman tests. - testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs())) + // testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs())) } if (!project.name.contains('gobblin-aws') && !project.name.contains('gobblin-distribution')) { configurations.compile.dependencies*.each { From 6c902d210d809d0164bb32fabf5e7851a863c5a3 Mon Sep 17 00:00:00 2001 From: William Lo Date: Thu, 31 Oct 2024 14:10:49 -0400 Subject: [PATCH 2/2] use newer setup java version --- .github/workflows/build_and_test.yaml | 6 +++--- gradle/scripts/globalDependencies.gradle | 6 +++++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml index 5149598ec15..70e15155751 100644 --- a/.github/workflows/build_and_test.yaml +++ b/.github/workflows/build_and_test.yaml @@ -38,13 +38,13 @@ jobs: runs-on: ubuntu-latest steps: - name: Check out the repo - uses: actions/checkout@v2 + uses: actions/checkout@v4 with: persist-credentials: false - name: Set up JDK 1.8 - uses: actions/setup-java@v1 + uses: actions/setup-java@v4 with: - java-version: 1.8 + java-version: 8 # Stores external dependencies, can be further improved with Gradle 6.1 - name: Cache Gradle Dependencies uses: actions/cache@v2 diff --git a/gradle/scripts/globalDependencies.gradle b/gradle/scripts/globalDependencies.gradle index feaa68a549f..0084f1c94b9 100644 --- a/gradle/scripts/globalDependencies.gradle +++ b/gradle/scripts/globalDependencies.gradle @@ -14,6 +14,10 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + +import javax.tools.ToolProvider + + subprojects { plugins.withType(JavaPlugin) { configurations { @@ -41,7 +45,7 @@ subprojects { customTestCompile externalDependency.slf4jToLog4j // Required to add JDK's tool jar, which is required to run byteman tests. - // testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs())) + testCompile (files(((URLClassLoader) ToolProvider.getSystemToolClassLoader()).getURLs())) } if (!project.name.contains('gobblin-aws') && !project.name.contains('gobblin-distribution')) { configurations.compile.dependencies*.each {