Optimize the code path in createFileset and optimize path.

[yuqi1129]

Code in HadoopCatalogOperations#createFileset

   try {
      // formalize the path to avoid path without scheme, uri, authority, etc.
      filesetPath = formalizePath(filesetPath, conf);

      FileSystem fs = getFileSystem(filesetPath, conf);
      if (!fs.exists(filesetPath)) {
        if (!fs.mkdirs(filesetPath)) {
          throw new RuntimeException(
              "Failed to create fileset " + ident + " location " + filesetPath);
        }

        LOG.info("Created fileset {} location {}", ident, filesetPath);
      } else {
        LOG.info("Fileset {} manages the existing location {}", ident, filesetPath);
      }

    } catch (IOException ioe) {
      throw new RuntimeException(
          "Failed to create fileset " + ident + " location " + filesetPath, ioe);
    

• filesetPath = formalizePath(filesetPath, conf);
• FileSystem fs = getFileSystem(filesetPath, conf);

These two lines will repeatedly get and initialize file system and can be merged into one

      AtomicReference<FileSystem> fileSystem = new AtomicReference<>();
      Awaitility.await()
          .atMost(timeoutSeconds, TimeUnit.SECONDS)
          .until(
              () -> {
                fileSystem.set(provider.getFileSystem(path, config));
                return true;
              });
      return fileSystem.get();

This code can be replaced to Java Future mechanism to reduce the time taken in poll status.

There may be other minor points to improve.

[Abyss-lord]

I would like to work on it.

[yuqi1129]

OK, just go ahead.