[#6570] improvement(core): Optimize fetching entity parent id logic #6574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengqm
reviewed
Mar 3, 2025
| Long parentEntityId = null; | ||
| if (namespace.levels().length >= 1) { | ||
| if (namespace.levels().length == 1) { |
There was a problem hiding this comment.
I can get the optimization logic here.
Can we further revise this logic into a switch...case for clarity?
|
This is nice. |
yuqi1129
requested review from
tengqm and
jerryshao
and removed request for
tengqm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
JOINto avoid fetching id several times when getting the parents of a fileset/table/topic/modelWhy are the changes needed?
It's very time-consuming to retrieve id from database several times.
Fix: #6570
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Existing UTs