Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog #6630

Closed
yuqi1129 opened this issue Mar 6, 2025 · 1 comment · Fixed by #6639
Closed

[Bug report] jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog #6630

yuqi1129 opened this issue Mar 6, 2025 · 1 comment · Fixed by #6639
Assignees
@sunxiaojian
Labels
bug Something isn't working

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Mar 6, 2025

Version

main branch

Describe what's wrong

When I create a MySQL catalog with property

Image

Though I have set the value jdbc.pool.test-on-borrow as false, the value of that in

Image

are still true.

Error message and/or stacktrace

Make that value take effect.

How to reproduce

Please see above

Additional context

No response
@yuqi1129 yuqi1129 added the bug Something isn't working label Mar 6, 2025
@yuqi1129 yuqi1129 changed the title [Bug report] jdbc.pool.test-on-borrow does not work when conecting to JDBC catalog [Bug report] jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog Mar 6, 2025
@sunxiaojian
Copy link
Contributor

@yuqi1129 please assign it to me.

@sunxiaojian sunxiaojian mentioned this issue Mar 7, 2025
Merged
github-actions bot pushed a commit that referenced this issue Mar 9, 2025
@sunxiaojian @web-flow
[#6630] fix(jdbc-catalog): jdbc.pool.test-on-borrow does not work whe…
cdeef9d 
…n connecting to JDBC catalog (#6639)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog

### Why are the changes needed?

Fix: #6630

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@github-actions github-actions bot mentioned this issue Mar 9, 2025
Merged
yuqi1129 pushed a commit that referenced this issue Mar 9, 2025
@github-actions @sunxiaojian
[#6630] fix(jdbc-catalog): jdbc.pool.test-on-borrow does not work whe…
5ba2fca 
…n connecting to JDBC catalog (#6643)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

jdbc.pool.test-on-borrow does not work when connecting to JDBC catalog

### Why are the changes needed?

Fix: #6630

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: Xiaojian Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunxiaojian sunxiaojian

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@sunxiaojian @yuqi1129