From 372fd2eb0cac4f9f232a0b364498830ef71d4811 Mon Sep 17 00:00:00 2001 From: Bertil Chapuis Date: Mon, 16 Sep 2024 11:57:12 +0200 Subject: [PATCH] Fix issues identified when executing the workflow - DataConversions should always call the wrapped methods - Only one log provider should be included in the project - Use MonotonicDataMap for coordinates and references --- .../org/apache/baremaps/workflow/WorkflowContext.java | 2 +- .../apache/baremaps/data/collection/DataConversions.java | 8 +------- .../apache/baremaps/data/collection/MonotonicDataMap.java | 1 - pom.xml | 6 ++++++ 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/baremaps-core/src/main/java/org/apache/baremaps/workflow/WorkflowContext.java b/baremaps-core/src/main/java/org/apache/baremaps/workflow/WorkflowContext.java index 349f30121..ba07839f0 100644 --- a/baremaps-core/src/main/java/org/apache/baremaps/workflow/WorkflowContext.java +++ b/baremaps-core/src/main/java/org/apache/baremaps/workflow/WorkflowContext.java @@ -64,7 +64,7 @@ public DataSource getDataSource(Object database) { } public Map getCoordinateMap() throws IOException { - return DataConversions.asMap(getMemoryAlignedDataMap("coordinates", new LonLatDataType())); + return DataConversions.asMap(getMonotonicDataMap("coordinates", new LonLatDataType())); } public Map> getReferenceMap() throws IOException { diff --git a/baremaps-data/src/main/java/org/apache/baremaps/data/collection/DataConversions.java b/baremaps-data/src/main/java/org/apache/baremaps/data/collection/DataConversions.java index 1211985d5..593f6acd4 100644 --- a/baremaps-data/src/main/java/org/apache/baremaps/data/collection/DataConversions.java +++ b/baremaps-data/src/main/java/org/apache/baremaps/data/collection/DataConversions.java @@ -270,13 +270,7 @@ public V put(K key, V value) { @Override public V get(Object key) { - if (map instanceof MemoryAlignedDataMap) { - return map.get(key); - } else if (map instanceof IndexedDataMap) { - return map.get(key); - } else { - return super.get(key); - } + return map.get(key); } @Override diff --git a/baremaps-data/src/main/java/org/apache/baremaps/data/collection/MonotonicDataMap.java b/baremaps-data/src/main/java/org/apache/baremaps/data/collection/MonotonicDataMap.java index 6a5b44674..25094823b 100644 --- a/baremaps-data/src/main/java/org/apache/baremaps/data/collection/MonotonicDataMap.java +++ b/baremaps-data/src/main/java/org/apache/baremaps/data/collection/MonotonicDataMap.java @@ -149,7 +149,6 @@ public Iterator> entryIterator() { .iterator(); } - /** {@inheritDoc} */ @Override public long size() { diff --git a/pom.xml b/pom.xml index d60471ea2..75f89b46b 100644 --- a/pom.xml +++ b/pom.xml @@ -237,6 +237,12 @@ limitations under the License. mil.nga.geopackage geopackage ${version.lib.geopackage} + + + org.slf4j + slf4j-nop + + net.ripe.ipresource