Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP)bugfix:Fix problems while using etcd3 as registry #7191

Closed
wants to merge 22 commits into from

Conversation

xingfudeshi
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7077

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi marked this pull request as draft March 4, 2025 06:15
@xingfudeshi xingfudeshi closed this Mar 4, 2025
@xingfudeshi xingfudeshi reopened this Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.56%. Comparing base (b530e30) to head (5bde4c7).

Files with missing lines Patch % Lines
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7191   +/-   ##
=========================================
  Coverage     51.56%   51.56%           
- Complexity     6811     6814    +3     
=========================================
  Files          1169     1169           
  Lines         41478    41478           
  Branches       4851     4851           
=========================================
+ Hits          21388    21389    +1     
- Misses        18069    18071    +2     
+ Partials       2021     2018    -3     
Files with missing lines Coverage Δ
...covery/registry/etcd3/EtcdRegistryServiceImpl.java 11.19% <0.00%> (ø)

... and 3 files with indirect coverage changes

@xingfudeshi xingfudeshi closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

etcd3 grpc version mismatch
1 participant