[Feedback] PR Review Bot

[lupyuen]

Please provide your feedback for the NuttX PR Review Bot. Thanks!

• Earlier Discussion: Update GitHub Pull Request Template. #13494 (comment)
• Source Code for PR Bot: nuttx-pr-bot
• PR Tips: "Preparing a Pull Request for Apache NuttX RTOS"

[raiden00pl]

My comment on this message from bot:

Squash The Commits: This PR contains 2 Commits. Please Squash the Multiple Commits into a Single Commit.

A suggestion like this shouldn't be based solely on the number of commits in PR.
What should be squashed and what shouldn't require a greater understanding of PR content.
Having multiple commits in one PR isn't always bad. Sometimes it's even necessary.

[lupyuen]

A suggestion like this shouldn't be based solely on the number of commits in PR.
What should be squashed and what shouldn't require a greater understanding of PR content.

Sorry @cederom and @acassis: What are your thoughts about this? Shall I remove the "Squash Commit" message, since our bot can't analyse the PR Content? Thanks!

[raiden00pl]

maybe we can just change "Please squash commits" to "consider squashing commits if that makes sense for this PR" (or something similar)

[lupyuen]

OK I removed the check for Squash Commits, I don't we're ready to handle it now :-)

[acassis]

Thank you @lupyuen I think it is better not to include it to avoid inducing contributors to wrong direction.

It could be something that reviewers could do better