Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Unified the argv parameters of pthread_create and kthread_create #14564

Open
1 task done
zyfeier opened this issue Oct 30, 2024 · 2 comments
Open
1 task done
Labels
Type: Enhancement New feature or request

Comments

@zyfeier
Copy link
Contributor

zyfeier commented Oct 30, 2024

Is your feature request related to a problem? Please describe.

Currently, the argv types of pthread_create and kthread_create are different, which can cause confusion during use.

Describe the solution you'd like

If the argv parameter of kthread_create can also be replaced with the void * type, it would achieve consistency in form and eliminate the need to dynamically calculate and store based on the number of argv arguments.

Describe alternatives you've considered

No response

Verification

  • I have verified before submitting the report.
@zyfeier zyfeier added the Type: Enhancement New feature or request label Oct 30, 2024
@zyfeier zyfeier changed the title [FEATURE] Unified the argv parameters of pthread_create and task_creat [FEATURE] Unified the argv parameters of pthread_create and kthread_create Nov 1, 2024
@xiaoxiang781216
Copy link
Contributor

some related issue: #1108

@xiaoxiang781216
Copy link
Contributor

xiaoxiang781216 commented Nov 1, 2024

@patacongo could you review this suggestion? which make kernel thread decouple from task creation code path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants