Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] run.mone:excel has dangerously outdated poi and xmlbeans dependencies #554

Open
pjfanning opened this issue Mar 7, 2025 · 6 comments

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Mar 7, 2025

https://mvnrepository.com/artifact/run.mone/excel/1.6.1-jdk21

POI and XMLBeans have CVEs. Excel is a very exploitable attack vector for malicious actors.

Please ditch run.mone/excel if they can't produce versions that use secure dependencies.

There only appears to be 1 class in this jar and it should be easy to copy the code into Ozhera instead of using the jar and to then update the code to use the latest POI and XMLBeans releases.

@pjfanning
Copy link
Contributor Author

If you look at XiaoMi/mone#1075, there are a number of poi and xmlbeans dependencies that seem unnecessary. Some of these jars are large and have CVEs.

@psxjoy
Copy link
Contributor

psxjoy commented Mar 8, 2025

This looks like a simple task.
Maybe we can pin this issue as a good first issue for a new contributor? @gaoxh

@gaoxh
Copy link
Contributor

gaoxh commented Mar 9, 2025

If you look at XiaoMi/mone#1075, there are a number of poi and xmlbeans dependencies that seem unnecessary. Some of these jars are large and have CVEs.

Thank you very much for your suggestion, which is very valuable to us. We will solve this problem as soon as possible. I am sorry that we ignored this problem before releasing the version. I am not sure whether this will affect our release of the current version. Can we reflect the fix of this problem in the next version?

@gaoxh
Copy link
Contributor

gaoxh commented Mar 9, 2025

This looks like a simple task. Maybe we can pin this issue as a good first issue for a new contributor? @gaoxh

That's a good suggestion, we'll improve it right away.

@gaoxh gaoxh pinned this issue Mar 9, 2025
@pjfanning
Copy link
Contributor Author

I have raised no issues that block the current RC from being released.

@gaoxh
Copy link
Contributor

gaoxh commented Mar 9, 2025

Thanks to pj, your help and suggestions have given me better ideas and methods to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants