HDDS-11347. Add rocks_tools_native lib check in Ozone CLI checknative subcommand

[smengcl]

What changes were proposed in this pull request?

Display rocks-tools native library loading result in Ozone CLI's checknative subcommand:

$ ./bin/ozone checknative

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11347

How was this patch tested?

• Added new test case to verify native rocks-tools lib loading
  • Passed: https://github.com/smengcl/hadoop-ozone/actions/runs/10525909716/job/29166171434#step:6:2676
• Manually tested:

# Compile under Linux
mvn clean install -Pdist -DskipTests -Pnative -Drocks_tools_native -e
# Check the output when rocks-tools native lib is loaded
cd hadoop-ozone/dist/target/ozone-*
./bin/ozone checknative

Output (Linux):

Native library checking:
hadoop:  false
ISA-L:   false
rocks-tools: true libozone_rocksdb_tools.so

Output (macOS):

Native library checking:
hadoop:  false 
ISA-L:   false 
rocks-tools: true libozone_rocksdb_tools.dylib

[hemantk-12]

Thanks, @smengcl for the patch. Change looks good to me.

@swamirishi Please take a look as well.

[swamirishi]

Thanks for the patch @smengcl . Changes look good to me apart from a nitpicky question I had.

[swamirishi]

Can we use NativeLibraryLoader.load(NativeConstants.ROCKS_TOOLS_NATIVE_LIBRARY_NAME) instead? Since we are checking if the rocks tools library gets loaded.

[smengcl]

Good idea. Done.

[smengcl]

The test failure is weird. I haven't touched anything related to hsync but its failing in one specific test:

https://github.com/apache/ozone/actions/runs/10728014894/job/30403969117?pr=7101#step:6:2770

Error:  Tests run: 41, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 507.786 s <<< FAILURE! - in org.apache.hadoop.fs.ozone.TestHSync
Error:  org.apache.hadoop.fs.ozone.TestHSync.testKeyHSyncThenClose  Time elapsed: 3.83 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at org.apache.hadoop.fs.ozone.TestHSync.testKeyHSyncThenClose(TestHSync.java:378)

And the line number doesn't even point to the right place in the test: Ah, after rebase, now it does

https://github.com/smengcl/hadoop-ozone/blob/HDDS-11347-checknative/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java#L378

Anyway, I've rebased (merged master) it. Let's see how it goes.