Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logical type MAP specification is unclear #468

Closed
gszadovszky opened this issue Nov 4, 2024 · 0 comments · Fixed by #469
Closed

Logical type MAP specification is unclear #468

gszadovszky opened this issue Nov 4, 2024 · 0 comments · Fixed by #469

Comments

@gszadovszky
Copy link
Contributor

Describe the enhancement requested

There are a couple of issues with the specification of the logical type MAP:

  • typo: "(...) optional or required and determines whether the list is nullable."
  • Based on the spec we allow to have a nested key column. Does it make sense? Most engines/libs require to use primitives for keys.
  • It is clear that value is not required, however I did not find a proper implementation to handle this. Do we want to suggest anything for this case (e.g. value column to be null)?
  • The Backward-compatibility rules suggests that key and value might not be named according to the spec. But does not say anything about how to identify them. I've seen multiple implementations (e.g. the avro binding of parquet-java), where we simply choose the 0th element as key and the 1st one as value without actually checking their names. It does not seem to be correct according on the spec.
  • Spec mentions that MAP_KEY_VALUE might appear at the place of MAP but doesn't mention its original purpose to tag key_value level.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant