Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code compiles on JDK 23 #1725

Closed
He-Pin opened this issue Jan 17, 2025 · 3 comments · Fixed by #1726
Closed

Make code compiles on JDK 23 #1725

He-Pin opened this issue Jan 17, 2025 · 3 comments · Fixed by #1726
Labels
build sbt or build of the project
Milestone
1.2.0-M1

Comments

@He-Pin
Copy link
Member

He-Pin commented Jan 17, 2025

The current code can't compile on JDK 23.
@He-Pin He-Pin added the build sbt or build of the project label Jan 17, 2025
@He-Pin He-Pin added this to the 1.2.0 milestone Jan 17, 2025
@pjfanning
Copy link
Contributor

see #1534

@pjfanning
Copy link
Contributor

My view is that we should disable the deprecated code checks when building with Java 23+ (ie not have scalac flags like -Werror and flags like that - that cause the build to fail if we use deprecated code). We can still use these scalac flags for Java 21 and below.

@He-Pin He-Pin mentioned this issue Jan 17, 2025
Merged
@He-Pin He-Pin linked a pull request Jan 17, 2025 that will close this issue
chore: Make code compiles on JDK 23 #1726
Merged
@He-Pin
Copy link
Member Author

He-Pin commented Jan 17, 2025

@pjfanning I think it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build sbt or build of the project
Projects
None yet
Milestone
1.2.0-M1
Development

Successfully merging a pull request may close this issue.

chore: Make code compiles on JDK 23 He-Pin/incubator-pekko
2 participants
@He-Pin @pjfanning