From 235847a7dc7186933d23f0a73e411510bf019a61 Mon Sep 17 00:00:00 2001 From: zhangliang Date: Thu, 19 Sep 2024 12:25:34 +0800 Subject: [PATCH] Add test cases on StatisticsCollectJobWorker --- .../collect/StatisticsCollectJobWorker.java | 15 ++-- .../StatisticsCollectJobWorkerTest.java | 71 +++++++++++++++++++ 2 files changed, 79 insertions(+), 7 deletions(-) create mode 100644 kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java diff --git a/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java b/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java index 0fce718990548..b84a776ebde88 100644 --- a/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java +++ b/kernel/schedule/core/src/main/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorker.java @@ -54,15 +54,16 @@ public final class StatisticsCollectJobWorker { * Initialize job worker. */ public void initialize() { - if (WORKER_INITIALIZED.compareAndSet(false, true)) { - ModeConfiguration modeConfig = contextManager.getComputeNodeInstanceContext().getModeConfiguration(); - if ("ZooKeeper".equals(modeConfig.getRepository().getType())) { - scheduleJobBootstrap = new ScheduleJobBootstrap(createRegistryCenter(modeConfig), new StatisticsCollectJob(contextManager), createJobConfiguration()); - scheduleJobBootstrap.schedule(); - return; - } + if (!WORKER_INITIALIZED.compareAndSet(false, true)) { + return; + } + ModeConfiguration modeConfig = contextManager.getComputeNodeInstanceContext().getModeConfiguration(); + if (!"ZooKeeper".equals(modeConfig.getRepository().getType())) { log.warn("Can not collect statistics because of unsupported cluster type: {}", modeConfig.getRepository().getType()); + return; } + scheduleJobBootstrap = new ScheduleJobBootstrap(createRegistryCenter(modeConfig), new StatisticsCollectJob(contextManager), createJobConfiguration()); + scheduleJobBootstrap.schedule(); } private CoordinatorRegistryCenter createRegistryCenter(final ModeConfiguration modeConfig) { diff --git a/kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java b/kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java new file mode 100644 index 0000000000000..dbe3978c4f4f2 --- /dev/null +++ b/kernel/schedule/core/src/test/java/org/apache/shardingsphere/schedule/core/job/statistics/collect/StatisticsCollectJobWorkerTest.java @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.schedule.core.job.statistics.collect; + +import lombok.SneakyThrows; +import org.apache.shardingsphere.elasticjob.lite.api.bootstrap.impl.ScheduleJobBootstrap; +import org.apache.shardingsphere.mode.manager.ContextManager; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.Answers; +import org.mockito.Mock; +import org.mockito.internal.configuration.plugins.Plugins; +import org.mockito.junit.jupiter.MockitoExtension; + +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.mockito.Mockito.verify; + +@ExtendWith(MockitoExtension.class) +class StatisticsCollectJobWorkerTest { + + private StatisticsCollectJobWorker jobWorker; + + @Mock(answer = Answers.RETURNS_DEEP_STUBS) + private ContextManager contextManager; + + @BeforeEach + void setUp() { + jobWorker = new StatisticsCollectJobWorker(contextManager); + } + + @Test + void assertInitializeTwice() { + jobWorker.initialize(); + jobWorker.initialize(); + verify(contextManager.getComputeNodeInstanceContext()).getModeConfiguration(); + } + + @Test + void assertInitializeWithNotZooKeeperRepository() { + jobWorker.initialize(); + assertNull(getScheduleJobBootstrap()); + } + + @Test + void assertDestroy() { + jobWorker.destroy(); + jobWorker.destroy(); + assertNull(getScheduleJobBootstrap()); + } + + @SneakyThrows(ReflectiveOperationException.class) + private ScheduleJobBootstrap getScheduleJobBootstrap() { + return (ScheduleJobBootstrap) Plugins.getMemberAccessor().get(StatisticsCollectJobWorker.class.getDeclaredField("scheduleJobBootstrap"), StatisticsCollectJobWorker.class); + } +}