Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] <Logging problem> There are questions about the fields recorded in the library #5606

Open
x519286925 opened this issue Aug 4, 2024 · 3 comments
Labels
type: question Further information is requested

Comments

@x519286925
Copy link

Question

image In decorator methods, the value of method is set to path,However, the field of the ShenyuRequestLog class is only the method field, which is used to record the request. As a result, the log logger does not know whether the user's request method is get or post. Method displays a path。

在上图中的decorator方法中,method的值被设置为path
但 ShenyuRequestLog这个类的字段只有 method 这个字段是记录请求方式,这会导致日志记录不知道用户的请求方式是 get 还是 post,method展示的是一个路径。

image

I don't know if it's a design or a bug

@x519286925 x519286925 added the type: question Further information is requested label Aug 4, 2024
@crudboy
Copy link
Contributor

crudboy commented Aug 5, 2024

Maybe I can try to fix it

@x519286925
Copy link
Author

Maybe I can try to fix it

thanks 😄

@crudboy
Copy link
Contributor

crudboy commented Aug 6, 2024

Method in other RPC plugins represents serviceName so added a requestMethod field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants