[Bug] the thrift plugin in javaagent doesn't handle exceptions.

[h0cheung]

Search before asking

• I had searched in the issues and found no similar issues.

Apache SkyWalking Component

Java Agent (apache/skywalking-java)

What happened

The thrift plugin can't handle exceptions.

The ProcessFunction has caught all exceptions except TTransportException for many years. So the plugin, which enhances TBaseProcessor cannot catch the exceptions. Then thrift server spans will never have errors unless a transport exception happens.

On the client side, the plugin works well. The thrift client spans will have errors when an exception happens.

What you expected to happen

If an exception happens, both server and client should have errors.

How to reproduce

Run a thrift server, which throw an custom Exception that will be returned to thrift client.

Then send requests to this server.

Anything else

For gRPC, the status code in response will be used to find errors. Maybe we should try to handle the response sent by thrift server.

Are you willing to submit a pull request to fix on your own?

• Yes I am willing to submit a pull request on my own!

Code of Conduct

• I agree to follow this project's Code of Conduct

[wu-sheng]

This is a common case, that some plugins are not powerful enough to collect everything.

If you or anyone is willing to enhance the plugin, that is great.

I am moving this from bug to discussion, as

1. This doesn't block anyone.
2. Plugin use cases are countless, it relies on the whole community users to collaborate, rather than maintainers' work.