[Feature] Fix the correct document link in Skywalking UI #9566
Replies: 6 comments 1 reply
-
We would not simply change that JSON in the runtime or use a variable. Because this JSON is generated from UI's edit mode. |
Beta Was this translation helpful? Give feedback.
-
Yep. So if those JSON files are dynamically created, we should change the do our best to provide an accurate document |
Beta Was this translation helpful? Give feedback.
-
Not that simple. UI is using the same GraphQL query to get the current value, so, when you do so, UI would show Then, link fails. (404) |
Beta Was this translation helpful? Give feedback.
-
You are right, of course not that simple. I mean that's just a grammar demo. |
Beta Was this translation helpful? Give feedback.
-
The difficulty is not about changing UI. The thing is, we don't have an API to provide a service like this, and we never think we should make things so complex. Read doc with the version you prefer/need, we assume this is a basic requirement for oss users. Also, when you take a look Function menu, it even links to a 3rd party page. You can see, as a widely adopted project, this is not a simple tech solution. |
Beta Was this translation helpful? Give feedback.
-
I am going to convert this to a discussion, nd close this. |
Beta Was this translation helpful? Give feedback.
-
Search before asking
Description
About the solutions discussed in this pr
The content we discussed in this link. My intention is not to add all old implementations to all the new features.
Because all versions of official documents in UI are linked to the latest version.
I find the code and resolution, perhaps we should link it to the corresponding version official document when we release the new version
like this
I'm not sure if those JSON files are dynamically created, I'm just determined that the source of the UI link is from here after I checked the Skywalking UI's code.
So it's just a demo, I don't want to submit a PR, maybe this change needs to be discussed.
I suggest adding this feature to 9.3.0.
And I also suggest the UI's LOGO or copyright should mark the current version, it will very helpful for new user
Use case
Every release should be linked to the corresponding version official document when we release the new version.
Related issues
No response
Are you willing to submit a PR?
Code of Conduct
Beta Was this translation helpful? Give feedback.
All reactions