Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Support tracing core web metrics in ClientJS #12020

Open
3 tasks done
Fine0830 opened this issue Mar 15, 2024 · 5 comments
Open
3 tasks done

[Feature] Support tracing core web metrics in ClientJS #12020

Fine0830 opened this issue Mar 15, 2024 · 5 comments
Assignees
@Fine0830
Labels
Client JS Browser agent feature New feature
Milestone
ClientJS - 1.0.0

Comments

@Fine0830
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Add new metrics, including Largest Contentful Paint(LCP), First Input Delay(FID), Cumulative Layout Shift(CLS)

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct
@Fine0830 Fine0830 added feature New feature Client JS Browser agent labels Mar 15, 2024
@Fine0830 Fine0830 added this to the ClientJS - 1.0.0 milestone Mar 15, 2024
@Fine0830 Fine0830 self-assigned this Mar 15, 2024
@Fine0830 Fine0830 mentioned this issue Sep 13, 2024
Merged
@wu-sheng
Copy link
Member

Could you update here about which metrics are added though which APIs? We need backend change to adopt this.

@Fine0830
Copy link
Member Author

I added clsTime, fidTime and lcpTime metrics and used /browser/perfData to report in client js. Batch processing metrics to avoid missing reported data, as different metrics need to be monitored and calculated at different stages.

@Fine0830 Fine0830 mentioned this issue Sep 14, 2024
Merged
@Fine0830
Copy link
Member Author

Fine0830 commented Sep 14, 2024 •
edited
Loading

Added isPV to the query(/browser/perfData) for identifying page view(PV). apache/skywalking-client-js#140

@Fine0830
Copy link
Member Author

Here is the api protocol

@wu-sheng
Copy link
Member

Could you update the API protocol doc? That doc should be aligned with this agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fine0830 Fine0830

Labels
Client JS Browser agent feature New feature
Projects
None yet
Milestone
ClientJS - 1.0.0
Development

No branches or pull requests
2 participants
@wu-sheng @Fine0830