[SPARK-54094][SQL] Extract common methods to KafkaOffsetReaderBase #52788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
When reviewing #52729, found that |
viirya
changed the title
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Given the size of code, we need JIRA ID for this PR, @viirya . 😄
Member
Author
|
Ha, okay @dongjoon-hyun 😄 |
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
Outdated
Show resolved
Hide resolved
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
Outdated
Show resolved
Hide resolved
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Oct 30, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (with the dedicated JIRA ID and a few style comments).
viirya
changed the title
Member
Author
|
Thank you @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch extracts the same method
getOffsetRangesFromResolvedOffsetsfrom twoKafkaOffsetReaderimplementations.Why are the changes needed?
When reviewing #52729, found that
KafkaOffsetReaderConsumerandKafkaOffsetReaderAdminhave the exactly samegetOffsetRangesFromResolvedOffsetsmethod. The method is actually long so seems good to extract them to common one.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No