Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking in the body of a Markdown component does not put it into edit mode. #32252

Open
3 tasks
rusackas opened this issue Feb 13, 2025 · 3 comments · May be fixed by #32335
Open
3 tasks

Clicking in the body of a Markdown component does not put it into edit mode. #32252

rusackas opened this issue Feb 13, 2025 · 3 comments · May be fixed by #32335
Assignees
@notHuman9504
Labels
dashboard:editmode Related to te Dashboard edit mode dashboard:markdown Related to the markdown component of the Dashboard

Comments

@rusackas
Copy link
Member

Bug description

You should be able to click anywhere on the component to edit the markdown. It seems that you have to click outside the content to get there right now.

Also, unclear if the Edit/Preview menu above the component should appear when hovering over the component... that might be nice. Or just scrap the thing (do people use it?)

Screenshots/recordings

MarkdownClickability.mp4

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added dashboard:editmode Related to te Dashboard edit mode dashboard:markdown Related to the markdown component of the Dashboard labels Feb 13, 2025
@rusackas rusackas added the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 14, 2025
@rusackas rusackas removed the v5.0 Label added by the release manager to track PRs to be included in the 5.0 branch label Feb 14, 2025
@notHuman9504
Copy link

notHuman9504 commented Feb 20, 2025 •
edited
Loading

@rusackas I have started working on this issue. So can you assign me this issue?

@sfirke sfirke assigned sfirke and notHuman9504 and unassigned sfirke Feb 20, 2025
@sfirke
Copy link
Member

sfirke commented Feb 20, 2025

Thanks @notHuman9504 , I have assigned you this issue. Since it's a bug in 5.0.0, which is in the release process, it would be appreciated if you could send this PR soon.

notHuman9504 added a commit to notHuman9504/superset that referenced this issue Feb 20, 2025
@notHuman9504
Fix issue apache#32252: solved the issue for switching preview and ed…
5c53b6b 
…it mode on click
@sadpandajoe sadpandajoe linked a pull request Feb 20, 2025 that will close this issue
Open
@notHuman9504
Copy link

notHuman9504 commented Feb 20, 2025 •
edited
Loading

@sfirke , @rusackas hope this will be fine.

Image

notHuman9504 added a commit to notHuman9504/superset that referenced this issue Feb 21, 2025
@notHuman9504
Fix issue apache#32252: Clicking in the body of a Markdown component …
40a4034 
…does not put it into edit mode
@michael-s-molina michael-s-molina moved this from New to Non-blockers in Apache Superset 5.0.0 Feb 21, 2025
notHuman9504 added a commit to notHuman9504/superset that referenced this issue Feb 21, 2025
@notHuman9504
Fix issue apache#32252: Clicking in the body of a Markdown component …
5e39efa 
…does not put it into edit mode
notHuman9504 added a commit to notHuman9504/superset that referenced this issue Feb 21, 2025
@notHuman9504
Fix issue apache#32252: Clicking in the body of a Markdown component …
60ca48a 
…does not put it into edit mode
notHuman9504 added a commit to notHuman9504/superset that referenced this issue Feb 21, 2025
@notHuman9504
Fix issue apache#32252: Clicking in the body of a Markdown component …
a660770 
…does not put it into edit mode
notHuman9504 added a commit to notHuman9504/superset that referenced this issue Feb 22, 2025
@notHuman9504
Fix issue apache#32252: Clicking in the body of a Markdown component …
963b3ea 
…does not put it into edit mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notHuman9504 notHuman9504

Labels
dashboard:editmode Related to te Dashboard edit mode dashboard:markdown Related to the markdown component of the Dashboard
Projects
Apache Superset 5.0.0
Status: Non-blockers
Milestone
No milestone
3 participants
@rusackas @sfirke @notHuman9504