Skip to content

Conversation

@ompharate
Copy link
Contributor

@ompharate ompharate commented Nov 26, 2025

fixes #36235

The Problem

In Apache Superset's dashboard list page /dashboard/list/ pagination controls were visible and working correctly in List View, but in Thumbnail/Card View, only the first 25 dashboards were displayed with no pagination controls visible, even when more dashboards existed in the database.

Root Cause

The [ListView] component renders two different sub-components based on view mode:

Table View: Uses [TableCollection] component, which internally includes pagination controls

Card View: Uses [CardCollection] component, which only renders cards without any pagination
The pagination state [pageIndex] [pageSize] [count] [gotoPage] existed in both views via the [useListViewState] hook, but the UI controls to navigate pages were never rendered in card view.

The Fix

Added pagination controls after the [CardCollection] component in card view, reusing the existing pagination state

Normal list view (Working Correctly)
Screenshot 2025-11-26 at 4 24 50 PM

tile/ thumbnail (No Pagination)
Screenshot 2025-11-26 at 4 24 39 PM

After Applying Fix
Screenshot 2025-11-26 at 4 34 04 PM
Screenshot 2025-11-26 at 4 34 10 PM

TESTING INSTRUCTIONS

Have >25 dashboards
Switch between:
List view
Thumbnail view
Confirm missing pagination

ADDITIONAL INFORMATION

  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Nov 26, 2025

Code Review Agent Run #9ab9a0

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 9c1c902..9c1c902
    • superset-frontend/src/components/ListView/ListView.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added change:frontend Requires changing the frontend listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. labels Nov 26, 2025
@ompharate
Copy link
Contributor Author

@justinpark @msyavuz When you get a chance, could you please review this? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend listview Namespace | Anything related to lists, such as Dashboards, Charts, Datasets, etc. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.0.0rc3] The dashboard list with thumbnails only shows 25 dashboards

1 participant