feat: add clang-tidy to CI

Author: junrushao

.github/workflows/ci_test.yml

@@ -50,7 +50,20 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+        with:
+          submodules: recursive
       - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd  # v3.0.1
+      - name: Set up uv
+        uses: astral-sh/setup-uv@b75a909f75acd358c2196fb9a5f1299a9a8868a4  # v6.7.0
+      - uses: ./.github/actions/detect-env-vars
+        id: env_vars
+      - name: Run clang-tidy
+        run: |
+          uv run --no-project --with "clang-tidy==21.1.1"     \
+            python tests/lint/clang_tidy_precommit.py         \
+              --build-dir=build-pre-commit                    \
+              --jobs=${{ steps.env_vars.outputs.cpu_count }}  \
+              ./src/ ./include ./tests
 
   doc:
     needs: [lint, prepare]

include/tvm/ffi/base_details.h

@@ -196,6 +196,7 @@ TVM_FFI_INLINE uint64_t StableHashCombine(uint64_t key, const T& value) {
  * \return the hash value.
  */
 TVM_FFI_INLINE uint64_t StableHashBytes(const void* data_ptr, size_t size) {
+  // NOLINTBEGIN(clang-analyzer-security.ArrayBound)
   const char* data = reinterpret_cast<const char*>(data_ptr);
   const constexpr uint64_t kMultiplier = 1099511628211ULL;
   const constexpr uint64_t kMod = 2147483647ULL;
@@ -211,14 +212,12 @@ TVM_FFI_INLINE uint64_t StableHashBytes(const void* data_ptr, size_t size) {
     // if alignment requirement is met, directly use load
     if (reinterpret_cast<uintptr_t>(it) % 8 == 0) {
       for (; it + 8 <= end; it += 8) {
-        // NOLINTNEXTLINE(clang-analyzer-security.ArrayBound)
         u.b = *reinterpret_cast<const uint64_t*>(it);
         result = (result * kMultiplier + u.b) % kMod;
       }
     } else {
       // unaligned version
       for (; it + 8 <= end; it += 8) {
-        // NOLINTNEXTLINE(clang-analyzer-security.ArrayBound)
         u.a[0] = it[0];
         u.a[1] = it[1];
         u.a[2] = it[2];
@@ -273,6 +272,7 @@ TVM_FFI_INLINE uint64_t StableHashBytes(const void* data_ptr, size_t size) {
     }
     result = (result * kMultiplier + u.b) % kMod;
   }
+  // NOLINTEND(clang-analyzer-security.ArrayBound)
   return result;
 }
 

include/tvm/ffi/container/array.h

@@ -447,7 +447,7 @@ class Array : public ObjectRef {
    * \tparam IterType The type of iterator
    */
   template <typename IterType>
-  Array(IterType first, IterType last) {
+  Array(IterType first, IterType last) {  // NOLINT(performance-unnecessary-value-param)
     static_assert(is_valid_iterator_v<T, IterType>,
                   "IterType cannot be inserted into a tvm::Array<T>");
     Assign(first, last);
@@ -817,7 +817,7 @@ class Array : public ObjectRef {
    * \tparam IterType The type of iterator
    */
   template <typename IterType>
-  void Assign(IterType first, IterType last) {
+  void Assign(IterType first, IterType last) {  // NOLINT(performance-unnecessary-value-param)
     int64_t cap = std::distance(first, last);
     if (cap < 0) {
       TVM_FFI_THROW(ValueError) << "cannot construct an Array of negative size";