Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Invalid invoking in the DelegationRssShuffleManager#getReader #2282

Closed
3 tasks done
zuston opened this issue Dec 10, 2024 · 0 comments · Fixed by #2283 · May be fixed by #2287
Closed
3 tasks done

[Bug] Invalid invoking in the DelegationRssShuffleManager#getReader #2282

zuston opened this issue Dec 10, 2024 · 0 comments · Fixed by #2283 · May be fixed by #2287

Comments

@zuston
Copy link
Member

zuston commented Dec 10, 2024

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

try {
      reader =
          (ShuffleReader<K, C>)
              delegate
                  .getClass()
                  .getDeclaredMethod(
                      "getReader",
                      ShuffleHandle.class,
                      int.class,
                      int.class,
                      int.class,
                      int.class,
                      TaskContext.class,
                      ShuffleReadMetricsReporter.class)
                  .invoke(
                      handle,
                      startMapIndex,
                      endMapIndex,
                      startPartition,
                      endPartition,
                      context,
                      metrics);
    } catch (Exception e) {
      throw new RssException(e);
    }

The delegation object is not propogated into the invoke method.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
zuston pushed a commit to zuston/incubator-uniffle that referenced this issue Dec 10, 2024
jerqi pushed a commit that referenced this issue Jan 1, 2025
…anager (#2283)

Co-authored-by: Junfan Zhang <[email protected]>

### What changes were proposed in this pull request?

Fix the bug of none object self when invoking the reflection method.

### Why are the changes needed?

Fix: #2282

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant