fix(rabbitmq): derive restore archive stem from target path - #3183
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## jasper/rabbitmq-candidate-base #3183 +/- ##
==============================================================
Coverage 0.00% 0.00%
==============================================================
Files 145 145
Lines 23153 23153
==============================================================
Misses 23153 23153 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
391767a to
52ff725
Compare
|
Runtime blocker on the integrated exact candidate Run: Direct restore Job evidence for all three target PVCs:
This disproves the PR's two-segment runtime assumption for this exact KB 1.2 path. The parent implementation at Full artifact SHA256: |
Problem
Volume-populator restore supplies
DP_TARGET_RELATIVE_PATHas<target-name>/<target-pod-name>.DP_BACKUP_BASE_PATHis already scoped to that relative path. Treating the full relative path as the archive stem makes restore look for<target-name>/<target-pod-name>.tar.zstinside the per-target base path, while backup writes<target-pod-name>.tar.zst.This addresses the current human review blocker on #3113 without changing the backup artifact layout.
Fix
DP_TARGET_POD_NAMEwhen the backup/restore job provides it.<target-name>/<target-pod-name>and derive only the final pod-name segment.DATASAFED_BACKEND_BASE_PATHequal to the injectedDP_BACKUP_BASE_PATH.<target>/<pod>shape and assert both base path and archive key.Validation
rabbitmq/rmq-br-5400-rabbitmq-2.tar.zst.rabbitmq/was incorrectly accepted as archive stemrabbitmqbefore the fail-closed guard.shellcheck addons/rabbitmq/dataprotection/restore.shbash -n addons/rabbitmq/dataprotection/restore.shgit diff --checkRuntime B/R evidence is intentionally not claimed by this static fix; the exact repinned candidate still needs same-identity backup/restore validation.