Tested cliUtils

Author: Adam Kliment

README.md

@@ -1,5 +1,3 @@
-# WARNING! NOT STABLE, UNDER STRONG DEVELOPMENT
-
 # Dredd—API Blueprint Testing Tool
 
 [![Build Status](https://travis-ci.org/apiaryio/dredd.png?branch=master)](https://travis-ci.org/apiaryio/dredd)

src/cli.coffee

@@ -19,19 +19,8 @@ cli = (configuration, callback) ->
           callback()
         else
           runtime = blueprintAstToRuntime result['ast']
-          if runtime['errors'].length > 0
-            cliUtils.exit 1
-            for error in runtime['errors']
-              message = error['message']
-              origin = error['origin']
 
-              cliUtils.log "Runtime compilation error: \"" + error['message'] + "\" on " + \
-                origin['resourceGroupName'] + \
-                ' > ' + origin['resourceName'] + \
-                ' > ' + origin['actionName'] 
-          
           if runtime['warnings'].length > 0
-            cliUtils.exit 1
             for warning in runtime['warnings']
               message = warning['message']
               origin = warning['origin']
@@ -41,6 +30,17 @@ cli = (configuration, callback) ->
                 ' > ' + origin['resourceName'] + \
                 ' > ' + origin['actionName'] 
 
+          if runtime['errors'].length > 0
+            for error in runtime['errors']
+              message = error['message']
+              origin = error['origin']
+
+              cliUtils.log "Runtime compilation error: \"" + error['message'] + "\" on " + \
+                origin['resourceGroupName'] + \
+                ' > ' + origin['resourceName'] + \
+                ' > ' + origin['actionName'] 
+            cliUtils.exit 1
+          
           tranasctionsWithConfigutration = []
 
           for transaction in runtime['transactions']

test/fixtures/warning-ambigous.apib

@@ -0,0 +1,40 @@
+FORMAT: X-1A
+
+# Machines API 
+# Group Machines
+
+# Machine [/machines/{name}]
+
+
+## Update a Machine [PUT]
+
++ Request (application/json)
+
+        {
+          "name": "waldo"
+        }
+
++ Response 200 (application/json)
+
+        {
+          "type": "bulldozer",
+          "name": "waldo",
+          "_id": "5229c6e8e4b0bd7dbb07e29c"
+        }
+
+## Retrieve a Machine [GET]
++ Parameters
+  + name (required,`waldo`)
+
++ Response 200 (text/plain)
+
+        {
+          "type": "bulldozer",
+          "name": "waldo",
+          "_id": "5229c6e8e4b0bd7dbb07e29c"
+        }
+
+## Delete Message [DELETE]
++ Parameters
+  + name (required,`waldo`)
++ Response 204

test/unit/cli-test.coffee

@@ -134,6 +134,26 @@ describe 'cli()', () ->
         assert.ok cliUtilsStub.exit.calledWith(1)
         done()     
 
+  describe 'when runtime contains any warning', () ->
+    before () ->
+      configuration =
+        blueprintPath: './test/fixtures/warning-ambigous.apib'
+        server: 'http://localhost:3000/'      
+      
+      executeTransactionStub.reset()
+
+    it 'should execute some transaction', (done) ->     
+      cli configuration, () ->
+        assert.ok executeTransactionStub.called
+        done()  
+
+    it 'should print runtime warnings to stdout'
+    
+    it 'should not exit', (done) ->
+       cli configuration, () ->
+        assert.ok cliUtilsStub.exit.calledWith(0)
+        done()     
+
   describe 'when runtime is without errors and warnings', () ->
     beforeEach () ->
       executeTransactionStub.reset()

test/unit/cli-utils-test.coffee

@@ -0,0 +1,39 @@
+{assert} = require 'chai'
+sinon = require 'sinon'
+cliUtils = require '../../src/cli-utils'
+
+describe 'cliUtils', () ->
+  describe 'exit', () ->
+    beforeEach () ->
+      sinon.stub process, 'exit'
+    
+    afterEach () ->
+      process.exit.restore()
+    
+    it 'should call process.exit', () ->
+      cliUtils.exit(0)
+      assert.ok process.exit.called
+
+
+  describe 'log', () ->
+    beforeEach () ->
+      sinon.stub console, 'log'
+    
+    afterEach () ->
+      console.log.restore()
+    
+    it 'should call console.log', () ->
+      cliUtils.log('log entry')
+      assert.ok console.log.called
+
+  describe 'error', () ->
+    beforeEach () ->
+      sinon.stub console, 'error'
+    
+    afterEach () ->
+      console.error.restore()
+    
+    it 'should call console.log', () ->
+      cliUtils.error('error entry')
+      assert.ok console.error.called
+