-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: compatible with snakeyaml-2.x #35
fix: compatible with snakeyaml-2.x #35
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
@richieyan 你的合并好像没有成功 |
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
============================================
+ Coverage 68.29% 68.35% +0.06%
- Complexity 1191 1193 +2
============================================
Files 169 169
Lines 5160 5161 +1
Branches 561 561
============================================
+ Hits 3524 3528 +4
+ Misses 1370 1369 -1
+ Partials 266 264 -2
|
Thanks for the PR, friend! Could you please update the CHANGES.md too? |
OK. |
So now snakeyaml 1.x and snakeyaml 2.x. Has the bug been fixed yet? @richieyan |
Yes, you can use snakeyaml 2.x when this PR merged. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Could you please check the repair code as soon as possible and merge PR? Recently, our project needs this repair version very much. Thank you! @nobodyiam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
since snakeyaml-2.x has removed empty args constructor, we need use the constructor with options
Which issue(s) this PR fixes:
Fixes #
apolloconfig/apollo#4960
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.