Allow empty descriptions and/or deprecationReasons

Author: martinbonnin

libraries/apollo-ast/src/commonMain/kotlin/com/apollographql/apollo/ast/SDLWriter.kt

@@ -47,7 +47,7 @@ open class SDLWriter(
 }
 
 internal fun SDLWriter.writeDescription(description: String?) {
-  if (!description.isNullOrBlank()) {
+  if (description != null) {
     write("\"\"\"${description.encodeToGraphQLTripleQuoted()}\"\"\"\n")
   }
 }

libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/java/helpers/Doc.kt

@@ -1,48 +1,45 @@
 package com.apollographql.apollo.compiler.codegen.java.helpers
 
 
-import com.apollographql.apollo.compiler.internal.applyIf
-import com.apollographql.apollo.compiler.codegen.java.JavaClassNames
 import com.apollographql.apollo.compiler.codegen.java.L
-import com.apollographql.apollo.compiler.codegen.java.S
+import com.apollographql.apollo.compiler.internal.applyIf
 import com.apollographql.apollo.compiler.ir.IrEnum
-import com.squareup.javapoet.AnnotationSpec
 import com.squareup.javapoet.FieldSpec
 import com.squareup.javapoet.MethodSpec
 import com.squareup.javapoet.TypeSpec
 
 internal fun TypeSpec.Builder.maybeAddDescription(description: String?): TypeSpec.Builder {
-  if (description.isNullOrBlank()) {
+  if (description == null) {
     return this
   }
 
   return addJavadoc("$L\n", description)
 }
 
 internal fun FieldSpec.Builder.maybeAddDescription(description: String?): FieldSpec.Builder {
-  if (description.isNullOrBlank()) {
+  if (description == null) {
     return this
   }
 
   return addJavadoc("$L\n", description)
 }
 
 internal fun TypeSpec.Builder.maybeAddDeprecation(deprecationReason: String?): TypeSpec.Builder {
-  if (deprecationReason.isNullOrBlank()) {
+  if (deprecationReason == null) {
     return this
   }
 
   return addJavadoc("$L\n", deprecationReason).addAnnotation(deprecatedAnnotation())
 }
 
 internal fun FieldSpec.Builder.maybeAddDeprecation(deprecationReason: String?): FieldSpec.Builder {
-  if (deprecationReason.isNullOrBlank()) {
+  if (deprecationReason == null) {
     return this
   }
 
   return addJavadoc("$L\n", deprecationReason).addAnnotation(deprecatedAnnotation())
 }
 
-internal fun MethodSpec.Builder.maybeSuppressDeprecation(enumValues: List<IrEnum.Value>): MethodSpec.Builder = applyIf(enumValues.any { !it.deprecationReason.isNullOrBlank() }) {
+internal fun MethodSpec.Builder.maybeSuppressDeprecation(enumValues: List<IrEnum.Value>): MethodSpec.Builder = applyIf(enumValues.any { it.deprecationReason != null }) {
   addAnnotation(suppressDeprecatedAnnotation())
 }

libraries/apollo-compiler/src/main/kotlin/com/apollographql/apollo/compiler/codegen/kotlin/helpers/KDoc.kt

@@ -14,31 +14,31 @@ import com.squareup.kotlinpoet.PropertySpec
 import com.squareup.kotlinpoet.TypeSpec
 
 internal fun TypeSpec.Builder.maybeAddDescription(description: String?): TypeSpec.Builder {
-  if (description.isNullOrBlank()) {
+  if (description == null) {
     return this
   }
 
   return addKdoc("%L", description.replace(' ', '♢'))
 }
 
 internal fun PropertySpec.Builder.maybeAddDescription(description: String?): PropertySpec.Builder {
-  if (description.isNullOrBlank()) {
+  if (description == null) {
     return this
   }
 
   return addKdoc("%L", description.replace(' ', '♢'))
 }
 
 internal fun ParameterSpec.Builder.maybeAddDescription(description: String?): ParameterSpec.Builder {
-  if (description.isNullOrBlank()) {
+  if (description == null) {
     return this
   }
 
   return addKdoc("%L", description.replace(' ', '♢'))
 }
 
 internal fun FunSpec.Builder.maybeAddDescription(description: String?): FunSpec.Builder {
-  if (description.isNullOrBlank()) {
+  if (description == null) {
     return this
   }
 
@@ -47,39 +47,39 @@ internal fun FunSpec.Builder.maybeAddDescription(description: String?): FunSpec.
 
 
 internal fun TypeSpec.Builder.maybeAddDeprecation(deprecationReason: String?): TypeSpec.Builder {
-  if (deprecationReason.isNullOrBlank()) {
+  if (deprecationReason == null) {
     return this
   }
 
   return addAnnotation(deprecatedAnnotation(deprecationReason))
 }
 
 internal fun PropertySpec.Builder.maybeAddDeprecation(deprecationReason: String?): PropertySpec.Builder {
-  if (deprecationReason.isNullOrBlank()) {
+  if (deprecationReason == null) {
     return this
   }
 
   return addAnnotation(deprecatedAnnotation(deprecationReason))
 }
 
 internal fun ParameterSpec.Builder.maybeAddDeprecation(deprecationReason: String?): ParameterSpec.Builder {
-  if (deprecationReason.isNullOrBlank()) {
+  if (deprecationReason == null) {
     return this
   }
 
   return addAnnotation(deprecatedAnnotation(deprecationReason))
 }
 
 internal fun FunSpec.Builder.maybeAddDeprecation(deprecationReason: String?): FunSpec.Builder {
-  if (deprecationReason.isNullOrBlank()) {
+  if (deprecationReason == null) {
     return this
   }
 
   return addAnnotation(deprecatedAnnotation(deprecationReason))
 }
 
 internal fun TypeSpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolver, optInFeature: String?): TypeSpec.Builder {
-  if (optInFeature.isNullOrBlank()) {
+  if (optInFeature == null) {
     return this
   }
 
@@ -88,7 +88,7 @@ internal fun TypeSpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolver, op
 }
 
 internal fun PropertySpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolver, optInFeature: String?): PropertySpec.Builder {
-  if (optInFeature.isNullOrBlank()) {
+  if (optInFeature == null) {
     return this
   }
 
@@ -97,7 +97,7 @@ internal fun PropertySpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolver
 }
 
 internal fun ParameterSpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolver, optInFeature: String?): ParameterSpec.Builder {
-  if (optInFeature.isNullOrBlank()) {
+  if (optInFeature == null) {
     return this
   }
 
@@ -106,7 +106,7 @@ internal fun ParameterSpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolve
 }
 
 internal fun FunSpec.Builder.maybeAddRequiresOptIn(resolver: KotlinResolver, optInFeature: String?): FunSpec.Builder {
-  if (optInFeature.isNullOrBlank()) {
+  if (optInFeature == null) {
     return this
   }
 
@@ -123,7 +123,7 @@ internal fun requiresOptInAnnotation(annotation: ClassName): AnnotationSpec {
 internal fun <T: Annotatable.Builder<*>> T.maybeAddOptIn(
     resolver: KotlinResolver,
     enumValues: List<IrEnum.Value>,
-): T = applyIf(enumValues.any { !it.optInFeature.isNullOrBlank() }) {
+): T = applyIf(enumValues.any { it.optInFeature != null }) {
   val annotation = resolver.resolveRequiresOptInAnnotation() ?: return@applyIf
   addAnnotation(requiresOptInAnnotation(annotation))
 }