Lint GH actions files

Author: smyrick

.github/workflows/test-k8s-deployment.yaml

@@ -1,10 +1,11 @@
+---
 name: Test Kubernetes Deployment
 
 on:
   pull_request:
     branches:
       - main
-  workflow_dispatch: # Allow manual triggering
+  workflow_dispatch:  # Allow manual triggering
 
 jobs:
   test-k8s-deployment:
@@ -28,16 +29,16 @@ jobs:
         run: |
           # Create kind cluster
           kind create cluster --name kind
-          
+
           # Verify cluster is running
           kind get clusters
-          
+
           # Verify nodes are ready
           kubectl get nodes
-          
+
           # Wait for cluster to be ready
           kubectl wait --for=condition=ready node --all --timeout=300s
-          
+
           echo "✅ Kind cluster is ready"
 
       - name: Install Docker Buildx
@@ -47,33 +48,33 @@ jobs:
         run: |
           cd subgraphs
           docker build -t subgraphs:test .
-          
+
           # Verify the image was created
           if ! docker images | grep -q "subgraphs.*test"; then
             echo "❌ Docker build failed for subgraphs"
             exit 1
           fi
-          
+
           echo "✅ Subgraphs Docker build successful"
-          
+
           # Load image into kind cluster
           kind load docker-image subgraphs:test
 
       - name: Test subgraphs container functionality
         run: |
           # Test subgraphs container locally before deploying to K8s
           docker run -d --name subgraphs-test -p 4001:4001 subgraphs:test
-          
+
           # Wait for container to start
           sleep 10
-          
+
           # Check if container is running
           if ! docker ps | grep -q "subgraphs-test"; then
             echo "❌ Subgraphs container failed to start"
             docker logs subgraphs-test
             exit 1
           fi
-          
+
           # Test all subgraph endpoints
           echo "Testing products endpoint..."
           curl -X POST http://localhost:4001/products/graphql \
@@ -82,25 +83,25 @@ jobs:
             --max-time 10 \
             --retry 3 \
             --retry-delay 2 || exit 1
-          
+
           echo "Testing reviews endpoint..."
           curl -X POST http://localhost:4001/reviews/graphql \
             -H "Content-Type: application/json" \
             -d '{"query":"{ __typename }"}' \
             --max-time 10 \
             --retry 3 \
             --retry-delay 2 || exit 1
-          
+
           echo "Testing users endpoint..."
           curl -X POST http://localhost:4001/users/graphql \
             -H "Content-Type: application/json" \
             -d '{"query":"{ allUsers { id username } }"}' \
             --max-time 10 \
             --retry 3 \
             --retry-delay 2 || exit 1
-          
+
           echo "✅ All subgraph endpoints responding"
-          
+
           # Cleanup test container
           docker stop subgraphs-test || true
           docker rm subgraphs-test || true
@@ -120,23 +121,27 @@ jobs:
           echo "Verifying kind cluster status..."
           kind get clusters
           kubectl get nodes
-          
+
           # Deploy using our scripts
           ./run-k8s.sh --replicas 1
-          
+
           # Wait for deployments to be ready
-          kubectl wait --for=condition=available --timeout=300s deployment/subgraphs -n apollo-supergraph
-          kubectl wait --for=condition=available --timeout=300s deployment/apollo-router -n apollo-supergraph
+          kubectl wait --for=condition=available --timeout=300s \
+            deployment/subgraphs -n apollo-supergraph
+          kubectl wait --for=condition=available --timeout=300s \
+            deployment/apollo-router -n apollo-supergraph
 
       - name: Test Kubernetes deployment
         run: |
           # Port forward to access services
-          kubectl port-forward svc/apollo-router-service 4000:4000 -n apollo-supergraph &
-          kubectl port-forward svc/subgraphs-service 4001:4001 -n apollo-supergraph &
-          
+          kubectl port-forward svc/apollo-router-service 4000:4000 \
+            -n apollo-supergraph &
+          kubectl port-forward svc/subgraphs-service 4001:4001 \
+            -n apollo-supergraph &
+
           # Wait for port forwarding
           sleep 10
-          
+
           # Test subgraphs directly in K8s
           echo "Testing subgraphs in Kubernetes..."
           curl -X POST http://localhost:4001/products/graphql \
@@ -145,7 +150,7 @@ jobs:
             --max-time 10 \
             --retry 3 \
             --retry-delay 2 || exit 1
-          
+
           # Test router in K8s
           echo "Testing router in Kubernetes..."
           curl -X POST http://localhost:4000/graphql \
@@ -154,17 +159,17 @@ jobs:
             --max-time 10 \
             --retry 3 \
             --retry-delay 2 || exit 1
-          
+
           echo "✅ Kubernetes deployment test successful"
 
       - name: Cleanup
         if: always()
         run: |
           # Stop port forwarding
           pkill -f "kubectl port-forward" || true
-          
+
           # Clean up deployment
           ./cleanup-k8s.sh || true
-          
+
           # Delete kind cluster
           kind delete cluster || true

.github/workflows/test.yaml

@@ -1,3 +1,4 @@
+---
 name: Test Apollo Supergraph
 
 on:
@@ -58,19 +59,19 @@ jobs:
         run: |
           cd router
           ./compose.sh
-          
+
           # Verify the supergraph file was created
           if [ ! -f "supergraph.graphql" ]; then
-            echo "❌ Supergraph composition failed - supergraph.graphql not created"
+            echo "❌ Supergraph composition failed - file not created"
             exit 1
           fi
-          
+
           # Verify the supergraph contains expected content
           if ! grep -q "join__Graph" supergraph.graphql; then
             echo "❌ Supergraph composition failed - missing join__Graph"
             exit 1
           fi
-          
+
           echo "✅ Supergraph composition successful"
 
   test-docker-builds:
@@ -87,13 +88,13 @@ jobs:
         run: |
           cd subgraphs
           docker build -t subgraphs:test .
-          
+
           # Verify the image was created
           if ! docker images | grep -q "subgraphs.*test"; then
             echo "❌ Docker build failed for subgraphs"
             exit 1
           fi
-          
+
           echo "✅ Subgraphs Docker build successful"
 
   test-scripts:
@@ -112,7 +113,7 @@ jobs:
               bash -n "$script" || exit 1
             fi
           done
-          
+
           # Test scripts in scripts directory
           if [ -d "scripts" ]; then
             for script in scripts/*.sh; do
@@ -122,7 +123,7 @@ jobs:
               fi
             done
           fi
-          
+
           echo "✅ All scripts have valid syntax"
 
       - name: Test script help options
@@ -133,7 +134,7 @@ jobs:
           ./kill-minikube.sh --help || exit 1
           ./setup-minikube.sh --help || exit 1
           ./setup-env.sh --help || exit 1
-          
+
           echo "✅ All script help options working"
 
   test-k8s-yaml:
@@ -158,33 +159,36 @@ jobs:
               fi
             done
           fi
-          
+
           # Test GitHub Actions workflows
           for workflow in .github/workflows/*.yaml; do
             if [ -f "$workflow" ]; then
               echo "Validating workflow: $workflow"
               yamllint "$workflow" || exit 1
             fi
           done
-          
+
           echo "✅ All YAML files have valid format"
 
       - name: Test Kubernetes manifest structure
         run: |
           # Basic structure validation without kubectl
           echo "Testing Kubernetes manifest structure..."
-          
+
           # Check if required files exist
-          required_files=("k8s/namespace.yaml" "k8s/subgraphs-deployment-clusterip.yaml" "k8s/router-deployment-clusterip.yaml" "k8s/ingress.yaml")
-          
+          required_files=("k8s/namespace.yaml" \
+            "k8s/subgraphs-deployment-clusterip.yaml" \
+            "k8s/router-deployment-clusterip.yaml" \
+            "k8s/ingress.yaml")
+
           for file in "${required_files[@]}"; do
             if [ ! -f "$file" ]; then
               echo "❌ Required Kubernetes manifest missing: $file"
               exit 1
             fi
             echo "✅ Found: $file"
           done
-          
+
           # Check for basic Kubernetes resource types
           for file in k8s/*.yaml; do
             if [ -f "$file" ]; then
@@ -199,5 +203,5 @@ jobs:
               fi
             fi
           done
-          
+
           echo "✅ All Kubernetes manifests have basic structure"