Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpLifecycleObserverTest.testCompleteEmptyMessageBody #2439

Closed
Scottmitch opened this issue Nov 23, 2022 · 2 comments
Closed

HttpLifecycleObserverTest.testCompleteEmptyMessageBody #2439

Scottmitch opened this issue Nov 23, 2022 · 2 comments
Labels
flaky tests Unit tests are flaky

Comments

@Scottmitch
Copy link
Member

https://github.com/apple/servicetalk/pull/2438/checks?check_run_id=9674873644

HttpLifecycleObserverTest.testCompleteEmptyMessageBody(HttpProtocol) [2] protocol=HTTP_2
org.mockito.exceptions.verification.NoInteractionsWanted: 
No interactions wanted here:
-> at io.servicetalk.http.netty.HttpLifecycleObserverTest.verifyObservers(HttpLifecycleObserverTest.java:398)
But found this interaction on mock 'serverRequestObserver':
-> at io.servicetalk.http.utils.BiHttpLifecycleObserver$BiHttpRequestObserver.onRequestDataRequested(BiHttpLifecycleObserver.java:133)
***
For your reference, here is the list of all invocations ([?] - means unverified).
1. -> at io.servicetalk.http.utils.BiHttpLifecycleObserver$BiHttpRequestObserver.onRequestComplete(BiHttpLifecycleObserver.java:160)
2. [?]-> at io.servicetalk.http.utils.BiHttpLifecycleObserver$BiHttpRequestObserver.onRequestDataRequested(BiHttpLifecycleObserver.java:133)

at app//io.servicetalk.http.netty.HttpLifecycleObserverTest.verifyObservers(HttpLifecycleObserverTest.java:398)
at app//io.servicetalk.http.netty.HttpLifecycleObserverTest.testCompleteEmptyMessageBody(HttpLifecycleObserverTest.java:155)
@Scottmitch
Copy link
Member Author

Unable to repro locally. I will try to update mockito (#2440) just in case, but assume the issue is on our side.

@idelpivnitskiy idelpivnitskiy added the flaky tests Unit tests are flaky label Oct 25, 2023
@idelpivnitskiy
Copy link
Member

This test was not flaky for almost a year and I did some improvements in this area. Will close this issue. If it happens again, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky tests Unit tests are flaky
Projects
None yet
Development

No branches or pull requests

2 participants