From a6874bcc5d6f8be7449bbf9690e46f849483310b Mon Sep 17 00:00:00 2001 From: Darshan Date: Sat, 12 Jul 2025 13:17:22 +0530 Subject: [PATCH 1/3] update: optimize logic for lesser elements in dom for tooltips. --- v2/pink-sb/src/lib/Popover.svelte | 46 +++++++++++----- v2/pink-sb/src/lib/Tooltip.svelte | 90 +++++++++++++++---------------- 2 files changed, 78 insertions(+), 58 deletions(-) diff --git a/v2/pink-sb/src/lib/Popover.svelte b/v2/pink-sb/src/lib/Popover.svelte index e4299eaa62..65c05be9dd 100644 --- a/v2/pink-sb/src/lib/Popover.svelte +++ b/v2/pink-sb/src/lib/Popover.svelte @@ -1,7 +1,8 @@ @@ -104,17 +120,21 @@ -
- -
+ +{#if showTooltip} +
+ +
+{/if} From 2f1e67d2ab50372e03dc1e3ccee5125916175bfb Mon Sep 17 00:00:00 2001 From: Darshan Date: Sat, 12 Jul 2025 13:29:44 +0530 Subject: [PATCH 2/3] fix: lint. --- v2/pink-sb/src/lib/Popover.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2/pink-sb/src/lib/Popover.svelte b/v2/pink-sb/src/lib/Popover.svelte index 65c05be9dd..db9e663bb2 100644 --- a/v2/pink-sb/src/lib/Popover.svelte +++ b/v2/pink-sb/src/lib/Popover.svelte @@ -2,7 +2,7 @@ import { fade } from 'svelte/transition'; import { activePopover } from './context.js'; import type { Placement } from '@floating-ui/dom'; - import { hasContext, tick, onDestroy } from 'svelte'; + import { hasContext, onDestroy } from 'svelte'; import { computePosition, autoUpdate, shift, offset, flip } from '@floating-ui/dom'; export let portal: boolean = false; From d6705b9435320a9913b454aa04ad98d5e7c88fcf Mon Sep 17 00:00:00 2001 From: Darshan Date: Mon, 14 Jul 2025 19:31:22 +0530 Subject: [PATCH 3/3] update: use action directives. --- v2/pink-sb/src/lib/Popover.svelte | 23 +++++++++-------------- v2/pink-sb/src/lib/Tooltip.svelte | 23 +++++++++-------------- 2 files changed, 18 insertions(+), 28 deletions(-) diff --git a/v2/pink-sb/src/lib/Popover.svelte b/v2/pink-sb/src/lib/Popover.svelte index db9e663bb2..74028a5720 100644 --- a/v2/pink-sb/src/lib/Popover.svelte +++ b/v2/pink-sb/src/lib/Popover.svelte @@ -1,8 +1,8 @@ @@ -130,6 +124,7 @@ class:padding-m={padding === 'm'} class:padding-none={padding === 'none'} use:portalPopover + use:autoUpdateAction transition:fade={{ duration: 150 }} > diff --git a/v2/pink-sb/src/lib/Tooltip.svelte b/v2/pink-sb/src/lib/Tooltip.svelte index a0bc476414..f9c52d8a57 100644 --- a/v2/pink-sb/src/lib/Tooltip.svelte +++ b/v2/pink-sb/src/lib/Tooltip.svelte @@ -1,5 +1,5 @@ @@ -88,6 +82,7 @@
(showing = false)} bind:this={tooltipElement} aria-hidden={!show}