-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a partial function macro @$
#7
Conversation
This looks cool! Give me a day or two to look through this in detail. I'm out of town and away from my computer currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! My one thought: would it be possible to merge the GeneralizedPartialFunction struct with the base PartialFunction struct? That way we can reduce some code duplication
Let me go through the implementation and try that. I agree it will reduce code duplication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm currently in the middle of fixing some of the CI on this repo. Once that is fixed, I'll try and run CI on this branch
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage ? 97.22%
=========================================
Files ? 2
Lines ? 72
Branches ? 0
=========================================
Hits ? 70
Misses ? 2
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
@JuliaRegistrator register |
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This allows us to create Partial Functions where arguments at arbitrary indices are missing.