Bridge listeners, file-manager header redundant code.

Signed-off-by: ubi de feo <me@ubidefeo.com>

Author: ubidefeo

backend/serial/serial-bridge.js

@@ -78,22 +78,26 @@ const SerialBridge = {
     return await ipcRenderer.invoke('serial', 'removeFile', file)
   },
   saveFileContent: async (filename, content, dataConsumer) => {
-    if (ipcRenderer.listeners("serial-on-file-save-progress").length > 0) {
-      ipcRenderer.removeAllListeners("serial-on-file-save-progress")
-    }
+    ipcRenderer.removeAllListeners("serial-on-file-save-progress")
     ipcRenderer.on('serial-on-file-save-progress', (event, progress) => {
       dataConsumer(progress)
     })
-    return await ipcRenderer.invoke('serial', 'saveFileContent', filename, content)
-  },
-  saveFileContentAtomic: async (filename, content, dataConsumer) => {
-    if (ipcRenderer.listeners("serial-on-file-save-progress").length > 0) {
+    try {
+      return await ipcRenderer.invoke('serial', 'saveFileContent', filename, content)
+    } finally {
       ipcRenderer.removeAllListeners("serial-on-file-save-progress")
     }
+  },
+  saveFileContentAtomic: async (filename, content, dataConsumer) => {
+    ipcRenderer.removeAllListeners("serial-on-file-save-progress")
     ipcRenderer.on('serial-on-file-save-progress', (event, progress) => {
       dataConsumer(progress)
     })
-    return await ipcRenderer.invoke('serial', 'saveFileContentAtomic', filename, content)
+    try {
+      return await ipcRenderer.invoke('serial', 'saveFileContentAtomic', filename, content)
+    } finally {
+      ipcRenderer.removeAllListeners("serial-on-file-save-progress")
+    }
   },
   uploadFile: async (src, dest, dataConsumer) => {
     if (ipcRenderer.listeners("serial-on-upload-progress").length > 0) {

ui/arduino/views/file-manager.js

@@ -16,15 +16,10 @@ function FileManagerView(state, emit) {
     const sourceSelected = source === 'board' ? boardSelected : diskSelected
     const selectionActive = sourceSelected.length > 0
 
-    const allowTransfer = source === 'board'
-      ? canDownload({ isConnected, selectedFiles })
-      : canUpload({ isConnected, selectedFiles })
     const allowOpen   = canEdit({ selectedFiles: sourceSelected })
     const allowRename = sourceSelected.length === 1
     const allowDelete = sourceSelected.length > 0
 
-    const transferIcon = source === 'board' ? 'download.svg' : 'upload.svg'
-
     const defaultButtons = html`
       <button disabled=${source === 'board' && !isConnected} onclick=${() => emit('create-folder', source)} data-tooltip="New folder">
         <img class="icon" src="media/new-folder.svg" />