Skip to content

Commit ee5c446

Browse files
committed
Added aria-labels for accessibility.
Signed-off-by: ubi de feo <me@ubidefeo.com>
1 parent 4b9347d commit ee5c446

3 files changed

Lines changed: 10 additions & 15 deletions

File tree

ui/arduino/views/components/file-actions.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,22 @@ function FileActions(state, emit, active = false) {
55
} = state
66
return html`
77
<div id="file-actions" class="${active ? 'active' : ''}" aria-hidden="${!active}">
8-
${Button({
8+
${active ? Button({
99
icon: 'arrow-left-white.svg',
1010
size: 'small',
1111
background: 'inverted',
1212
active: true,
1313
disabled: !canUpload({ isConnected, selectedFiles }),
1414
onClick: () => emit('upload-files')
15-
})}
16-
${Button({
15+
}) : null}
16+
${active ? Button({
1717
icon: 'arrow-right-white.svg',
1818
size: 'small',
1919
background: 'inverted',
2020
active: true,
2121
disabled: !canDownload({ isConnected, selectedFiles }),
2222
onClick: () => emit('download-files')
23-
})}
23+
}) : null}
2424
</div>
2525
`
2626
}

ui/arduino/views/components/file-list.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,6 @@ function generateFileList(source) {
4646
f => f.fileName === item.fileName && f.source === source
4747
)
4848

49-
function renameItem(e) {
50-
e.preventDefault()
51-
emit('rename-file', source, item)
52-
return false
53-
}
5449
let clickTimer = null
5550
function handleClick(e) {
5651
clearTimeout(clickTimer)

ui/arduino/views/file-manager.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,25 +21,25 @@ function FileManagerView(state, emit) {
2121
const allowDelete = sourceSelected.length > 0
2222

2323
const defaultButtons = html`
24-
<button disabled=${source === 'board' && !isConnected} onclick=${() => emit('create-folder', source)} data-tooltip="New folder">
24+
<button disabled=${source === 'board' && !isConnected} onclick=${() => emit('create-folder', source)} data-tooltip="New folder" aria-label="New folder">
2525
<img class="icon" src="media/new-folder.svg" />
2626
</button>
27-
<button disabled=${source === 'board' && !isConnected} onclick=${() => emit('create-file', source)} data-tooltip="New file">
27+
<button disabled=${source === 'board' && !isConnected} onclick=${() => emit('create-file', source)} data-tooltip="New file" aria-label="New file">
2828
<img class="icon" src="media/new-file.svg" />
2929
</button>
3030
`
3131

3232
const selectionButtons = html`
33-
<button disabled=${!allowOpen} onclick=${() => emit('open-selected-files')} data-tooltip="Open">
33+
<button disabled=${!allowOpen} onclick=${() => emit('open-selected-files')} data-tooltip="Open" aria-label="Open">
3434
<img class="icon" src="media/open.svg" />
3535
</button>
36-
<button disabled=${!allowRename} onclick=${() => emit('rename-file', source, sourceSelected[0])} data-tooltip="Rename">
36+
<button disabled=${!allowRename} onclick=${() => emit('rename-file', source, sourceSelected[0])} data-tooltip="Rename" aria-label="Rename">
3737
<img class="icon" src="media/rename_v2.svg" />
3838
</button>
39-
<button disabled=${!allowDelete} onclick=${() => emit('remove-files', source)} data-tooltip="Delete">
39+
<button disabled=${!allowDelete} onclick=${() => emit('remove-files', source)} data-tooltip="Delete" aria-label="Delete">
4040
<img class="icon" src="media/delete.svg" />
4141
</button>
42-
<button class="header-checkbox" onclick=${() => emit('clear-selection-by-source', source)} data-tooltip="Deselect all">
42+
<button class="header-checkbox" onclick=${() => emit('clear-selection-by-source', source)} data-tooltip="Deselect all" aria-label="Deselect all">
4343
<img class="icon" src="media/clear-checked.svg" />
4444
</button>
4545
`

0 commit comments

Comments
 (0)