uDisplay: is parameter USE_UNIVERSAL_TOUCH useless?

[hawa-lc4]

Hello,
just a short question.
Starting uDisplay as a replacement for legacy display handling also Universal Touch was introduced.
Most simple displays (e.g. OLED) do not hav touch at all so uDisplay is needed but there is no need touch control.
If Universal Touch shall be disabled in user_config_override.ini file by #undef USE_UNIVERSAL_TOUCH this is ignored and set in
library file "lib/lib_display/uDisplay/include/uDisplay_config.h" (lines 23 ff.) anyway.
Due to this a lot of additional things are activated in other parts of tasmota components and libraries.

Q: is this really intended to work this way?
Why not using "USE_UNIVERSAL_TOUCH" the same way as "USE_UNIVERSAL_DISPLAY" is used; if set it is activated, if not set it is fully disabled?

[s-hadinger]

Good point. This seems to have been added 6 months ago by 309cdd6#diff-f73b8e67d28bd7c9973040640a6273bfc0f0d927925396b39b05ccf29f42fdd2 by @Jason2866

Let's try what happens if we remove it

[s-hadinger]

Actually it does compile fine when removing

#ifndef USE_UNIVERSAL_TOUCH
#define USE_UNIVERSAL_TOUCH
#endif

in uDisplay_config.h and saves 3.8KB

[s-hadinger]

PR #24743 in CI, ready to merge if ok with you @Jason2866

[Jason2866]

@s-hadinger if it compiles it is fine. Regression from refactor of UDisplay driver.

[s-hadinger]

Merged, let's see if any side-effect.

@hawa-lc4 thanks for reporting this issue