Skip to content

Conversation

@aali309
Copy link
Contributor

@aali309 aali309 commented Nov 4, 2025

Fixes: #21209
Part of: #21209
Replaces: argoproj/gitops-engine#654

This PR Improves error messages when attempting to modify immutable fields in StatefulSets by showing exactly which fields changed and their before/after values.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Before the change:

Screenshot 2025-11-05 at 1 02 21 PM

After the change:

Screenshot 2025-11-05 at 1 00 10 PM

@bunnyshell
Copy link

bunnyshell bot commented Nov 4, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@aali309 aali309 self-assigned this Nov 4, 2025
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.22%. Comparing base (d6f25a1) to head (dbb9c63).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25171      +/-   ##
==========================================
- Coverage   62.24%   62.22%   -0.03%     
==========================================
  Files         351      351              
  Lines       49231    49231              
==========================================
- Hits        30643    30633      -10     
- Misses      15663    15673      +10     
  Partials     2925     2925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aali309 aali309 marked this pull request as ready for review November 5, 2025 18:06
@aali309 aali309 requested a review from a team as a code owner November 5, 2025 18:06
@aali309 aali309 force-pushed the reportAndFormatViolatedFieldError branch from 15120c0 to c8b37ac Compare November 6, 2025 20:05
@aali309 aali309 force-pushed the reportAndFormatViolatedFieldError branch from c8b37ac to dbb9c63 Compare November 7, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant