evmasm: Support struct array copying from memory/calldata to storage in evmasm pipeline

Author: r0qs

libsolidity/codegen/ArrayUtils.cpp

@@ -71,18 +71,6 @@ void ArrayUtils::copyArrayToStorage(ArrayType const& _targetType, ArrayType cons
 			"Copying nested calldata dynamic arrays to storage is not implemented in the old code generator."
 		);
 	}
-	else
-	{
-		// TODO: This limitation can now be removed since we use Yul utility functions that handle non-value types correctly.
-		// The old inline assembly implementation couldn't handle copying arrays of non-value types from memory or calldata to storage,
-		// but the Yul functions support them. We keep this check temporarily for backward compatibility.
-		bool fromMemoryOrCalldata = _sourceType.location() == DataLocation::Memory || _sourceType.location() == DataLocation::CallData;
-		solUnimplementedAssert(
-			_sourceType.baseType()->isValueType() || !fromMemoryOrCalldata,
-			"Copying of type " + _sourceType.toString(false) + " to storage is not supported in legacy (only supported by the IR pipeline). " +
-			"Hint: try compiling with `--via-ir` (CLI) or the equivalent `viaIR: true` (Standard JSON)."
-		);
-	}
 
 	if (haveSourceLengthOnStack)
 	{

test/libsolidity/semanticTests/array/copying/array_of_struct_calldata_to_storage.sol

@@ -1,4 +1,4 @@
-pragma abicoder               v2;
+pragma abicoder v2;
 
 contract C {
     struct S {
@@ -13,8 +13,8 @@ contract C {
         return (s[2].a, s[1].b, s[0].c);
     }
 }
-// ====
-// compileViaYul: true
 // ----
 // f((uint128,uint64,uint128)[]): 0x20, 3, 0, 0, 12, 0, 11, 0, 10, 0, 0 -> 10, 11, 12
 // gas irOptimized: 120751
+// gas legacy: 126254
+// gas legacyOptimized: 121447

test/libsolidity/semanticTests/array/copying/array_of_struct_memory_to_storage.sol

@@ -15,8 +15,8 @@ contract C {
         return (s[2].a, s[1].b, s[0].c);
     }
 }
-// ====
-// compileViaYul: true
 // ----
 // f() -> 10, 11, 12
 // gas irOptimized: 118796
+// gas legacy: 124947
+// gas legacyOptimized: 119164

test/libsolidity/semanticTests/array/copying/array_of_structs_containing_arrays_calldata_to_storage.sol

@@ -1,4 +1,4 @@
-pragma abicoder               v2;
+pragma abicoder v2;
 
 contract C {
     struct S {
@@ -19,8 +19,8 @@ contract C {
         return (s[1].a.length, s[1].a[0]);
     }
 }
-// ====
-// compileViaYul: true
 // ----
 // f((uint256[])[]): 0x20, 3, 0x60, 0x60, 0x60, 0x20, 3, 1, 2, 3 -> 3, 1
 // gas irOptimized: 327461
+// gas legacy: 332254
+// gas legacyOptimized: 327667

test/libsolidity/semanticTests/array/copying/array_of_structs_containing_arrays_memory_to_storage.sol

@@ -1,4 +1,4 @@
-pragma abicoder               v2;
+pragma abicoder v2;
 
 contract C {
     struct S {
@@ -22,8 +22,8 @@ contract C {
         return (s[1].b.length, s[1].c.length, s[1].b[2], s[1].c[0]);
     }
 }
-// ====
-// compileViaYul: true
 // ----
 // f() -> 3, 3, 3, 1
 // gas irOptimized: 181928
+// gas legacy: 190874
+// gas legacyOptimized: 183072