[bazel] Run buildifier on Bazel build files

This is an automated change with the following commands:

$ find . -name "BUILD.bazel" -o -name "*.bzl" \
  -exec buildifier -lint=fix {} \;

* Add missing `load()` statements for things provided by @rules_cc. This
  is required for Bazel >9.
* Sort attributes on build targets.
* Add missing trailing commas where applicable.

Author: armandomontanez

bazel/BUILD.bazel

@@ -1,3 +1,4 @@
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("@rules_python//python:defs.bzl", "py_binary")
 
 package(default_visibility = ["//visibility:public"])

bazel/defs.bzl

@@ -1,5 +1,7 @@
 load("@bazel_skylib//rules:write_file.bzl", "write_file")
 load("@rules_cc//cc:defs.bzl", "cc_library")
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
 
 def _pico_generate_pio_header_impl(ctx):
     generated_headers = []

bazel/pico_btstack_make_gatt_header.bzl

@@ -1,4 +1,6 @@
 load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cpp_toolchain", "use_cc_toolchain")
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
 
 def _pico_btstack_make_gatt_header_impl(ctx):
     cc_toolchain = find_cpp_toolchain(ctx)
@@ -21,7 +23,6 @@ def _pico_btstack_make_gatt_header_impl(ctx):
             "-I",
             ctx.file._btstack_hdr.dirname,
         ] + [
-
         ],
         inputs = [
             ctx.file.src,
@@ -37,7 +38,7 @@ def _pico_btstack_make_gatt_header_impl(ctx):
 
     return [
         DefaultInfo(files = depset(direct = [out])),
-        CcInfo(compilation_context = cc_ctx)
+        CcInfo(compilation_context = cc_ctx),
     ]
 
 pico_btstack_make_gatt_header = rule(

bazel/toolchain/BUILD.bazel

@@ -100,7 +100,7 @@ cc_args(
             "-Og",
             "-g3",
         ],
-    })
+    }),
 )
 
 cc_args(
@@ -115,7 +115,7 @@ cc_args(
             "-O2",
             "-DNDEBUG",
         ],
-    })
+    }),
 )
 
 cc_args(
@@ -128,7 +128,7 @@ cc_args(
         "//bazel/constraint:pico_compilation_no_fastbuild_args_set": [],
         # The conditions default are kept as nothing here, The bazel docs default are -gmlt -Wl,-S.
         "//conditions:default": [],
-    })
+    }),
 )
 
 configurable_toolchain_feature(
@@ -163,7 +163,6 @@ configurable_toolchain_feature(
     linkopts = ["-Wl,-z,max-page-size=4096"],
 )
 
-
 cc_feature(
     name = "dbg",
     args = [":debug_args"],
@@ -203,30 +202,13 @@ _HOST_CPU_CONSTRAINTS = {
 
 [cc_toolchain(
     name = "arm_gcc_{}-{}_toolchain_cortex-m".format(host_os, host_cpu),
-    tool_map = "@arm_gcc_{}-{}//:all_tools".format(host_os, host_cpu),
     args = select({
         "//bazel/constraint:rp2040": [":cortex-m0"],
         "//bazel/constraint:rp2350": [":cortex-m33"],
         "//conditions:default": [],
     }) + [
         ":bazel_no_absolute_paths",
     ],
-    exec_compatible_with = [
-        _HOST_CPU_CONSTRAINTS[host_cpu],
-        _HOST_OS_CONSTRAINTS[host_os],
-    ],
-    tags = ["manual"],  # Don't try to build this in wildcard builds.
-    known_features = [
-        "@rules_cc//cc/toolchains/args:experimental_replace_legacy_action_config_features",
-        "@pico-sdk//bazel/toolchain:dbg",
-        "@pico-sdk//bazel/toolchain:opt",
-        "@pico-sdk//bazel/toolchain:fastbuild",
-        "@pico-sdk//bazel/toolchain:gc_sections",
-        "@pico-sdk//bazel/toolchain:cxx_no_exceptions",
-        "@pico-sdk//bazel/toolchain:cxx_no_rtti",
-        "@pico-sdk//bazel/toolchain:cxx_no_cxa_atexit",
-        "@pico-sdk//bazel/toolchain:override_max_page_size",
-    ],
     enabled_features = [
         "@rules_cc//cc/toolchains/args:experimental_replace_legacy_action_config_features",
     ] + select({
@@ -245,11 +227,27 @@ _HOST_CPU_CONSTRAINTS = {
         "//bazel/constraint:pico_use_default_max_page_size_enabled": [],
         "//conditions:default": [":override_max_page_size"],
     }),
+    exec_compatible_with = [
+        _HOST_CPU_CONSTRAINTS[host_cpu],
+        _HOST_OS_CONSTRAINTS[host_os],
+    ],
+    known_features = [
+        "@rules_cc//cc/toolchains/args:experimental_replace_legacy_action_config_features",
+        "@pico-sdk//bazel/toolchain:dbg",
+        "@pico-sdk//bazel/toolchain:opt",
+        "@pico-sdk//bazel/toolchain:fastbuild",
+        "@pico-sdk//bazel/toolchain:gc_sections",
+        "@pico-sdk//bazel/toolchain:cxx_no_exceptions",
+        "@pico-sdk//bazel/toolchain:cxx_no_rtti",
+        "@pico-sdk//bazel/toolchain:cxx_no_cxa_atexit",
+        "@pico-sdk//bazel/toolchain:override_max_page_size",
+    ],
+    tags = ["manual"],  # Don't try to build this in wildcard builds.
+    tool_map = "@arm_gcc_{}-{}//:all_tools".format(host_os, host_cpu),
 ) for host_os, host_cpu in HOSTS]
 
 [cc_toolchain(
     name = "clang_{}-{}_toolchain_cortex-m".format(host_os, host_cpu),
-    tool_map = "@clang_{}-{}//:all_tools".format(host_os, host_cpu),
     args = select({
         "//bazel/constraint:rp2040": [
             ":armv6m-none-eabi",
@@ -264,22 +262,6 @@ _HOST_CPU_CONSTRAINTS = {
         ":bazel_no_absolute_paths",
         ":llvm-libc_args",
     ],
-    exec_compatible_with = [
-        _HOST_CPU_CONSTRAINTS[host_cpu],
-        _HOST_OS_CONSTRAINTS[host_os],
-    ],
-    tags = ["manual"],  # Don't try to build this in wildcard builds.
-    known_features = [
-        "@rules_cc//cc/toolchains/args:experimental_replace_legacy_action_config_features",
-        "@pico-sdk//bazel/toolchain:dbg",
-        "@pico-sdk//bazel/toolchain:opt",
-        "@pico-sdk//bazel/toolchain:fastbuild",
-        "@pico-sdk//bazel/toolchain:gc_sections",
-        "@pico-sdk//bazel/toolchain:cxx_no_exceptions",
-        "@pico-sdk//bazel/toolchain:cxx_no_rtti",
-        "@pico-sdk//bazel/toolchain:cxx_no_cxa_atexit",
-        "@pico-sdk//bazel/toolchain:override_max_page_size",
-    ],
     enabled_features = [
         "@rules_cc//cc/toolchains/args:experimental_replace_legacy_action_config_features",
     ] + select({
@@ -298,6 +280,23 @@ _HOST_CPU_CONSTRAINTS = {
         "//bazel/constraint:pico_use_default_max_page_size_enabled": [],
         "//conditions:default": [":override_max_page_size"],
     }),
+    exec_compatible_with = [
+        _HOST_CPU_CONSTRAINTS[host_cpu],
+        _HOST_OS_CONSTRAINTS[host_os],
+    ],
+    known_features = [
+        "@rules_cc//cc/toolchains/args:experimental_replace_legacy_action_config_features",
+        "@pico-sdk//bazel/toolchain:dbg",
+        "@pico-sdk//bazel/toolchain:opt",
+        "@pico-sdk//bazel/toolchain:fastbuild",
+        "@pico-sdk//bazel/toolchain:gc_sections",
+        "@pico-sdk//bazel/toolchain:cxx_no_exceptions",
+        "@pico-sdk//bazel/toolchain:cxx_no_rtti",
+        "@pico-sdk//bazel/toolchain:cxx_no_cxa_atexit",
+        "@pico-sdk//bazel/toolchain:override_max_page_size",
+    ],
+    tags = ["manual"],  # Don't try to build this in wildcard builds.
+    tool_map = "@clang_{}-{}//:all_tools".format(host_os, host_cpu),
 ) for host_os, host_cpu in HOSTS]
 
 [toolchain(

bazel/toolchain/configurable_feature.bzl

@@ -3,7 +3,6 @@ load("@rules_cc//cc/toolchains:args_list.bzl", "cc_args_list")
 load("@rules_cc//cc/toolchains:feature.bzl", "cc_feature")
 
 def configurable_toolchain_feature(name, copts = [], cxxopts = [], linkopts = []):
-
     all_args = []
 
     if copts:

bazel/toolchain/objcopy.bzl

@@ -1,5 +1,6 @@
 load("@bazel_tools//tools/build_defs/cc:action_names.bzl", "OBJ_COPY_ACTION_NAME")
 load("@rules_cc//cc:find_cc_toolchain.bzl", "find_cpp_toolchain", "use_cc_toolchain")
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
 
 def _objcopy_to_bin_impl(ctx):
     cc_toolchain = find_cpp_toolchain(ctx)

bazel/util/label_flag_matches.bzl

@@ -1,7 +1,6 @@
 """A wrapper that enables a `config_setting` matcher for label_flag flags."""
 
 load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
-load("@bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain", "use_cpp_toolchain")
 
 def _match_label_flag_impl(ctx):
     matches = str(ctx.attr.expected_value.label) == str(ctx.attr.flag.label)

bazel/util/sdk_define.bzl

@@ -1,4 +1,6 @@
 load("@bazel_skylib//rules:common_settings.bzl", "BuildSettingInfo")
+load("@rules_cc//cc/common:cc_common.bzl", "cc_common")
+load("@rules_cc//cc/common:cc_info.bzl", "CcInfo")
 
 def _pico_sdk_define_impl(ctx):
     val = ctx.attr.from_flag[BuildSettingInfo].value

bazel/util/transition.bzl

@@ -93,7 +93,7 @@ rp2040_bootloader_binary = declare_transtion(
         "_allowlist_function_transition": attr.label(
             default = "@bazel_tools//tools/allowlists/function_transition_allowlist",
         ),
-	"_link_extra_libs": attr.label(default = "//bazel:empty_cc_lib"),
+        "_link_extra_libs": attr.label(default = "//bazel:empty_cc_lib"),
     },
     flag_overrides = {
         # We don't want --custom_malloc to ever apply to the bootloader, so
@@ -104,7 +104,7 @@ rp2040_bootloader_binary = declare_transtion(
         # binary via `link_extra_libs`, so we must drop these deps when
         # building the bootloader binaries themselves in order to avoid a
         # circular dependency.
-	"@bazel_tools//tools/cpp:link_extra_libs": "_link_extra_libs",
+        "@bazel_tools//tools/cpp:link_extra_libs": "_link_extra_libs",
     },
 )
 

src/boards/BUILD.bazel

@@ -1,3 +1,4 @@
+load("@rules_cc//cc:cc_library.bzl", "cc_library")
 load("//bazel:defs.bzl", "pico_board_config")
 load("//bazel/util:multiple_choice_flag.bzl", "declare_flag_choices", "flag_choice")