Skip to content

Commit c75431f

Browse files
committed
api-docs: Updated docs for certain endpoint parameters.
In zulip/python-zulip-api#634, certain endpoint parameters were encoded to make the function callable by passing the arguements, rather than passing them as a dictionary. Following api endpoints are affected within the docs: POST update_presence GET get_members PATCH mute_topic POST render_message POST create_user POST set_typing_status
1 parent 6ee74b3 commit c75431f

File tree

1 file changed

+13
-46
lines changed

1 file changed

+13
-46
lines changed

zerver/openapi/python_examples.py

Lines changed: 13 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -153,13 +153,7 @@ def get_user_presence(client: Client) -> None:
153153

154154
@openapi_test_function("/users/me/presence:post")
155155
def update_presence(client: Client) -> None:
156-
request = {
157-
"status": "active",
158-
"ping_only": False,
159-
"new_user_input": False,
160-
}
161-
162-
result = client.update_presence(request)
156+
result = client.update_presence(status="active", ping_only=False, new_user_input=False)
163157

164158
assert result["result"] == "success"
165159

@@ -169,18 +163,13 @@ def create_user(client: Client) -> None:
169163

170164
# {code_example|start}
171165
# Create a user
172-
request = {
173-
"email": "[email protected]",
174-
"password": "temp",
175-
"full_name": "New User",
176-
}
177-
result = client.create_user(request)
166+
result = client.create_user(email="[email protected]", password="temp", full_name="New User")
178167
# {code_example|end}
179168

180169
validate_against_openapi_schema(result, "/users", "post", "200")
181170

182171
# Test "Email already used error"
183-
result = client.create_user(request)
172+
result = client.create_user(email="[email protected]", password="temp", full_name="New User")
184173

185174
validate_against_openapi_schema(result, "/users", "post", "400")
186175

@@ -202,16 +191,16 @@ def get_members(client: Client) -> None:
202191
assert newbie["full_name"] == "New User"
203192

204193
# {code_example|start}
205-
# You may pass the `client_gravatar` query parameter as follows:
206-
result = client.get_members({"client_gravatar": True})
194+
# You may pass the `client_gravatar` argument as follows:
195+
result = client.get_members(client_gravatar=True)
207196
# {code_example|end}
208197

209198
validate_against_openapi_schema(result, "/users", "get", "200")
210199
assert result["members"][0]["avatar_url"] is None
211200

212201
# {code_example|start}
213-
# You may pass the `include_custom_profile_fields` query parameter as follows:
214-
result = client.get_members({"include_custom_profile_fields": True})
202+
# You may pass the `include_custom_profile_fields` argument as follows:
203+
result = client.get_members(include_custom_profile_fields=True)
215204
# {code_example|end}
216205

217206
validate_against_openapi_schema(result, "/users", "get", "200")
@@ -560,25 +549,14 @@ def toggle_mute_topic(client: Client) -> None:
560549

561550
# {code_example|start}
562551
# Mute the topic "boat party" in the stream "Denmark"
563-
request = {
564-
"stream": "Denmark",
565-
"topic": "boat party",
566-
"op": "add",
567-
}
568-
result = client.mute_topic(request)
552+
result = client.mute_topic(stream="Denmark", topic="boat party", op="add")
569553
# {code_example|end}
570554

571555
validate_against_openapi_schema(result, "/users/me/subscriptions/muted_topics", "patch", "200")
572556

573557
# {code_example|start}
574558
# Unmute the topic "boat party" in the stream "Denmark"
575-
request = {
576-
"stream": "Denmark",
577-
"topic": "boat party",
578-
"op": "remove",
579-
}
580-
581-
result = client.mute_topic(request)
559+
result = client.mute_topic(stream="Denmark", topic="boat party", op="remove")
582560
# {code_example|end}
583561

584562
validate_against_openapi_schema(result, "/users/me/subscriptions/muted_topics", "patch", "200")
@@ -649,10 +627,7 @@ def render_message(client: Client) -> None:
649627

650628
# {code_example|start}
651629
# Render a message
652-
request = {
653-
"content": "**foo**",
654-
}
655-
result = client.render_message(request)
630+
result = client.render_message(content="**foo**")
656631
# {code_example|end}
657632

658633
validate_against_openapi_schema(result, "/messages/render", "post", "200")
@@ -1076,11 +1051,7 @@ def set_typing_status(client: Client) -> None:
10761051
user_id1 = 10
10771052
user_id2 = 11
10781053

1079-
request = {
1080-
"op": "start",
1081-
"to": [user_id1, user_id2],
1082-
}
1083-
result = client.set_typing_status(request)
1054+
result = client.set_typing_status(op="start", to=[user_id1, user_id2])
10841055
# {code_example|end}
10851056

10861057
validate_against_openapi_schema(result, "/typing", "post", "200")
@@ -1090,11 +1061,7 @@ def set_typing_status(client: Client) -> None:
10901061
user_id1 = 10
10911062
user_id2 = 11
10921063

1093-
request = {
1094-
"op": "stop",
1095-
"to": [user_id1, user_id2],
1096-
}
1097-
result = client.set_typing_status(request)
1064+
result = client.set_typing_status(op="stop", to=[user_id1, user_id2])
10981065
# {code_example|end}
10991066

11001067
validate_against_openapi_schema(result, "/typing", "post", "200")
@@ -1206,7 +1173,7 @@ def test_invalid_api_key(client_with_invalid_key: Client) -> None:
12061173

12071174

12081175
def test_missing_request_argument(client: Client) -> None:
1209-
result = client.render_message({})
1176+
result = client.render_message()
12101177

12111178
validate_against_openapi_schema(result, "/rest-error-handling", "post", "400_1")
12121179

0 commit comments

Comments
 (0)