Script will produce garbage when more than 1 battery or external power supply is present.

[dreirund]

I just hat a look into the batfetch bash-script.

On many places, you use /sys/class/power_supply/BAT*.

The BAT* (and also A* for "AC" adapters) assumes that there is maximum 1 battery and at maximum one external power supply present. But that is not always true. There exist machines with more than 1 battery; your script will produce garbage in this cases.

I think a solution would be to check which devices are there, and if it is more than one either make a seperate display for each, or per default display the lowest one, and in both cases allow the user to optionally specify which to use.

Regards!

[ashish-kus]

Thank you for taking the time to review the batfetch bash-script and for bringing up the concern regarding the use of /sys/class/power_supply/BAT* and A* assumptions.

I sincerely appreciate your keen observation, and I must admit that I was aware of this limitation during the initial development phase. Regrettably, I did not possess the appropriate hardware at that time to thoroughly test scenarios involving multiple batteries or external power supplies.

I will be dedicating time to implement a solution that dynamically checks the available devices and allows for separate displays or user-specified preferences when multiple batteries or power supplies are present. This will ensure a more reliable and versatile user experience.

Thank you once again for your valuable contribution to the project, and I look forward to resolving this matter satisfactorily.

[ashish-kus]

Could you please share the logs or information about the file structure of /sys/class/power_supply/BAT* for systems with multiple batteries? This will help enhance the batfetch script's compatibility.

Thank you!

[dreirund]

Could you please share the logs or information about the file structure of /sys/class/power_supply/BAT* for systems with multiple batteries?

I currently do not have such a system (I had previously), but just assume that there is /sys/class/power_supply/BAT1, /sys/class/power_supply/BAT5 etc. and /sys/class/power_supply/ADP0, /sys/class/power_supply/AC0 and such directories, with similar files within them.

[ashish-kus]

To accurately address and resolve this issue, I would need the precise file structure and contents within these directories on a system with multiple batteries. If someone from the community who has such a setup could provide this structure or any relevant details, it would greatly support a solution.

Until then, I encourage any community member interested in tackling this issue to explore it and, if possible, submit a pull request. Your contributions would be invaluable in advancing this project.

Thank you for your understanding and support!

[dreirund]

To accurately address and resolve this issue, I would need the precise file structure and contents within these directories on a system with multiple batteries.

They are just similar. Think of another directory with same content.

And: Also if there is just one battery or external power input, the contents can differ.

Some systems report power and charge in W and Wh, some in A and Ah; and that also results in differing filenames (power* vs. current* e.g.).