Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are multiple templates named 'leaderboard' #482

Open
tab00 opened this issue Nov 20, 2017 · 8 comments
Open

There are multiple templates named 'leaderboard' #482

tab00 opened this issue Nov 20, 2017 · 8 comments

Comments

@tab00
Copy link

tab00 commented Nov 20, 2017

After updating to 0.8.43 I saw the above error in the console, and the app doesn't load.

I downgraded to 0.8.42 and my app is working again.

Please fix this problem so that we can use the latest version.

Thank you.

@aslagle
Copy link
Owner

aslagle commented Nov 20, 2017

Sorry about that. The only thing I changed in 0.8.43 was the dependency on underscore to fix #481, and I don't see how that would cause this problem. It's commit c81598a.

Maybe meteor publish did something weird. In that case it wouldn't help to revert the change and publish again. Any ideas?

@harrisonhunter
Copy link

I also saw this behavior and was unable to build render my application correctly because of issues with the leaderboard template:
https://www.dropbox.com/s/q59392gj6zzv6cf/Screenshot%202017-11-19%2023.04.18.png?dl=0
reverting made it work normally

@aslagle
Copy link
Owner

aslagle commented Nov 20, 2017

Weird. The leaderboard template is used in examples but they're not supposed to be part of the package. I published with a newer version of meteor than I've used in the past so maybe it included those files even though they're not listed in package.js. I haven't been keeping up with the changes to meteor.

@rmuratov
Copy link

rmuratov commented Nov 20, 2017

Can confirm, same issue with multiple templates with one name. Switched back to 0.8.42, everything works fine. Maybe changes in build process.

EDIT Having no other ideas I tried replacing old api.add_files with api.addFiles etc (as suggested in docs). Without any success. For now I ended up with removing the whole examples dir.

@s7dhansh thought the same about eager loading, but what's the point of adding files explicitly then...

@s7dhansh
Copy link
Contributor

I think the leaderboard template is being compiled multiple times as it is not in imports directory. The new meteor version for packages would have become more in sync with the normal apps, by eagerly loading everything in non-imports.

@aslagle
Copy link
Owner

aslagle commented Nov 20, 2017

I published 0.8.44 with an older version of meteor to see if it fixes the problem. I didn't make any other changes. Let me know if it works.

aslagle added a commit that referenced this issue Nov 20, 2017
@s7dhansh
Copy link
Contributor

s7dhansh commented Nov 20, 2017

Yes it does. The meteor shell issue is also fixed.

@rmuratov
Copy link

Yes, that worked for me as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants