Rewrite six.PY2 ternary

[asottile]

2 if six.PY2 else 3

this one is going to be quite tricky I imagine

[graingert]

I'd probably implement this as two steps, one to replace six.PY2 with False and another to remove unreachable branches

[graingert]

@asottile here's a tool that does automatic dead code removal: coala/coala-bears#2000

[asottile]

@graingert note that this is already done for if statements, just not for ternary expressions -- no need to do two passes

vulture doesn't help here -- that dead code detection is similar to dead and doesn't at all help us to remove code

the detection part is simple, the "finding the end and beginning of the ternary expression" is hard

[graingert]

it seems they've managed to get it to apply removals to dead code detections jendrikseipp/vulture#25

[asottile]

cool, but it doesn't help us here

[atugushev]

Hm... The trickiest part is to rewrite:

3 if six.PY3 else 2

to

3

[asottile]

I think they're both nearly impossible given we don't properly know expression boundaries (though maybe the new python3.8 stuff helps?)

[ngnpope]

I wonder if PEP 657 might help with this?

(It makes reference to branch differentiation in ternary statements w.r.t. coverage.)

[asottile]

it does not help, we are not running code

[ngnpope]

it does not help, we are not running code

Of course. 🤦🏻‍♂️ Sorry for the noise. 🙂