Screenshot path is not calculated correctly for absolute paths

[ysb33r]

If I run something like

$ cd /working/dir
$  decktape --screenshots --screenshot-format jpg --screenshots-directory /path1 reveal \
   file:///path/to/source/index.html /path2/index.pdf

then the screenshot directory is calculated as /path1/path2/. I would not expect it to append the parent path from index.pdf to the screenshot directory.

The only way to get it work correctly atm, is to calculate the relative path from /working/dir back up to the filesystem root and then pass that as the screenshot directory and output to the same folder as where the PDF will be.

$  decktape --screenshots --screenshot-format jpg --screenshots-directory ../.. reveal \
   file:///path/to/source/index.html /path2/index.pdf

[ysb33r]

There is an additional issue to this. When using something like ../.. on Windows, the path to the screenshot file will be illegal. For example for C:\path2\index.pdf it will resolve the JPG file to C:\C:\path2\index.pdf. (Yes, the drive letter is repeated).

This will cause an issue for us in the v3.0 release of the Asciidoctor Gradle plugin (asciidoctor/asciidoctor-gradle-plugin#381)

[gitpitch]

I have a local patched decktape to workaround this problem. My solution was to treat any path passed on the --screenshots-directory flag as an absolute path. In decktape.js, I simply replaced the current implementation with this:

path           : path.join(options.screenshotDirectory,
          `_${context.currentSlide}_${resolution.width}x${resolution.height}.${options.screenshotFormat}`),

This approach would seem to solve the immediate issue, ie. current path.join logic is broken. And it would also seem to address any issues related to platform specific paths. I think. So perhaps it might make sense to adopt this approach here, as a general fix for the handling of this flag. Just food for thought.

[cavo789]

Thanks @gitpitch , your workaround is working; had the same problem.

I'm running the latest version of decktape i.e. 2.11.0