Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Examples #1

Open
oxzi opened this issue Oct 15, 2020 · 0 comments
Open

Outdated Examples #1

oxzi opened this issue Oct 15, 2020 · 0 comments

Comments

@oxzi
Copy link

oxzi commented Oct 15, 2020

First, thanks a lot for all the great work in astroid. Today I tried to play with its plugin system and hit some barriers.

Since astroid version 0.14, WebKit was replaced by WebKit 2.0. This change was missed in the ThreadViewPlugin example. WebKit should be replaced with WebKit2.

The signature of the get_avatar_uri method was updated in astroidmail/astroid@3cccc7b. Without the new message parameter, ThreadViewPlugin.do_get_avatar_uri will not be called.

I would propose to update the threadview.py file accordingly. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant