Skip to content

Commit fbded10

Browse files
authored
Merge pull request #297 from braingram/min_deps
increase minimum asdf and astropy
2 parents 07d68c0 + c6ee771 commit fbded10

File tree

3 files changed

+7
-13
lines changed

3 files changed

+7
-13
lines changed

CHANGES.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
------------------
33

44
- drop support for numpy 1.25. [#285]
5+
- require asdf 3.3 and drop support for astropy 5.2 [#297]
56

67
0.8.0 (2025-06-11)
78
------------------

asdf_astropy/converters/unit/tests/test_quantity.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,11 @@
44
from asdf.testing import helpers
55
from astropy import units
66
from astropy.units import Quantity
7-
from astropy.utils.introspection import minversion
87
from numpy.testing import assert_array_equal
98

109
from asdf_astropy.tests.versions import ASTROPY_GE_7_1
1110

1211

13-
def asdf_open_memory_mapping_kwarg(memmap: bool) -> dict:
14-
if minversion("asdf", "3.1.0"):
15-
return {"memmap": memmap}
16-
return {"copy_arrays": not memmap}
17-
18-
1912
def create_quantities():
2013
return [
2114
# Scalar:
@@ -104,7 +97,7 @@ def test_memmap(tmp_path):
10497
af.write_to(file_path)
10598

10699
# Update a value in the ASDF file
107-
with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=True)) as af:
100+
with asdf.open(file_path, mode="rw", memmap=True) as af:
108101
assert (af.tree["quantity"] == quantity).all()
109102
assert af.tree["quantity"][-1, -1] != new_value
110103

@@ -114,7 +107,7 @@ def test_memmap(tmp_path):
114107
assert (af.tree["quantity"] != quantity).any()
115108
assert (af.tree["quantity"] == new_quantity).all()
116109

117-
with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=True)) as af:
110+
with asdf.open(file_path, mode="rw", memmap=True) as af:
118111
assert af.tree["quantity"][-1, -1] == new_value
119112
assert (af.tree["quantity"] != quantity).any()
120113
assert (af.tree["quantity"] == new_quantity).all()
@@ -137,7 +130,7 @@ def test_no_memmap(tmp_path):
137130
af.write_to(file_path)
138131

139132
# Update a value in the ASDF file
140-
with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=False)) as af:
133+
with asdf.open(file_path, mode="rw", memmap=False) as af:
141134
assert (af.tree["quantity"] == quantity).all()
142135
assert af.tree["quantity"][-1, -1] != new_value
143136

@@ -147,7 +140,7 @@ def test_no_memmap(tmp_path):
147140
assert (af.tree["quantity"] != quantity).any()
148141
assert (af.tree["quantity"] == new_quantity).all()
149142

150-
with asdf.open(file_path, mode="rw", **asdf_open_memory_mapping_kwarg(memmap=False)) as af:
143+
with asdf.open(file_path, mode="rw", memmap=False) as af:
151144
assert af.tree["quantity"][-1, -1] != new_value
152145
assert (af.tree["quantity"] != new_quantity).any()
153146
assert (af.tree["quantity"] == quantity).all()

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ dynamic = [
1414
'version',
1515
]
1616
dependencies = [
17-
"asdf>=2.15.0",
17+
"asdf>=3.3.0",
1818
"asdf-coordinates-schemas>=0.4",
1919
"asdf-transform-schemas>=0.6",
2020
"asdf-standard>=1.1.0",
21-
"astropy>=5.2.0",
21+
"astropy>=5.3.0",
2222
"numpy>=1.26",
2323
"packaging>=19",
2424
]

0 commit comments

Comments
 (0)