Skip to content

BUGFIX: isinstance check is wrong #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
keflavich wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

BUGFIX: isinstance check is wrong #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
967744b
socket.socket is redefined under normal use of turn_internet_off; the…
keflavich Jun 11, 2025
bf1fb0b
improve behavior: check whether a remote-accessing function is being …
keflavich Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pytest_remotedata/disable_internet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ def check_internet_off(original_function, allow_astropy_data=False,
"""

def new_function(*args, **kwargs):
if socket.socket != socket_original:
raise OSError(f"Internet status is INTERNET_OFF={INTERNET_OFF}, "
"but a remote function was created.")
if isinstance(args[0], socket.socket):
if not args[0].family in (socket.AF_INET, socket.AF_INET6):
# Should be fine in all but some very obscure cases
Expand Down