Skip to content

Commit b29cdcb

Browse files
authored
Get proper attributes from queue (#598)
* Get proper attributes from queue * Bugfxi * cs
1 parent af10009 commit b29cdcb

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

Diff for: src/AsyncAwsSqsQueue.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
namespace AsyncAws\Illuminate\Queue;
44

55
use AsyncAws\Illuminate\Queue\Job\AsyncAwsSqsJob;
6-
use AsyncAws\Sqs\Enum\MessageSystemAttributeName;
76
use AsyncAws\Sqs\Enum\QueueAttributeName;
87
use AsyncAws\Sqs\SqsClient;
98
use Illuminate\Contracts\Queue\Job;
@@ -139,7 +138,7 @@ public function pop($queue = null)
139138
{
140139
$response = $this->sqs->receiveMessage([
141140
'QueueUrl' => $queue = $this->getQueue($queue),
142-
'AttributeNames' => [MessageSystemAttributeName::APPROXIMATE_RECEIVE_COUNT],
141+
'AttributeNames' => [QueueAttributeName::ALL],
143142
]);
144143

145144
foreach ($response->getMessages() as $message) {

Diff for: tests/Unit/AsyncAwsSqsQueueTest.php

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
use AsyncAws\Illuminate\Queue\AsyncAwsSqsQueue;
99
use AsyncAws\Illuminate\Queue\Job\AsyncAwsSqsJob;
1010
use AsyncAws\Illuminate\Queue\Tests\Resource\CreateUser;
11-
use AsyncAws\Sqs\Enum\MessageSystemAttributeName;
1211
use AsyncAws\Sqs\Enum\QueueAttributeName;
1312
use AsyncAws\Sqs\Result\GetQueueAttributesResult;
1413
use AsyncAws\Sqs\Result\ReceiveMessageResult;
@@ -199,7 +198,7 @@ public function testPop()
199198
return false;
200199
}
201200

202-
if ([MessageSystemAttributeName::APPROXIMATE_RECEIVE_COUNT] !== $input['AttributeNames']) {
201+
if (['All'] !== $input['AttributeNames']) {
203202
return false;
204203
}
205204

0 commit comments

Comments
 (0)