Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Newsletter page does not have correct button labels #3236

Open
2 tasks done
JeelRajodiya opened this issue Sep 15, 2024 · 10 comments · May be fixed by #3308
Open
2 tasks done

[BUG] Newsletter page does not have correct button labels #3236

JeelRajodiya opened this issue Sep 15, 2024 · 10 comments · May be fixed by #3308
Labels
bug

Comments

@JeelRajodiya
Copy link
Contributor

JeelRajodiya commented Sep 15, 2024 •
edited
Loading

Describe the bug.

The labels for the buttons and input fields simply have the i18n placeholders instead of the actual labels

image
image

Expected behavior

These are the expected labels

image

How to Reproduce

  1. Go to https://www.asyncapi.com/newsletter or https://www.asyncapi.com/community/tsc
  2. You will notice the improper labels

🥦 Browser

Google Chrome

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

No, someone else can work on it
@jayp5545
Copy link

I can work on it!

@hkv24 hkv24 mentioned this issue Sep 15, 2024
Closed
@sambhavgupta0705
Copy link
Member

How do we access newsletter page?

@JeelRajodiya
Copy link
Contributor Author

How do we access newsletter page?

I am not sure either, I was just going through the codebase and found that we have pages/newsletter.tsx file. Which means the page exists at https://www.asyncapi.com/newsletter

image

@sambhavgupta0705
Copy link
Member

@akshatnema do we need this url as we only have newsletter at the home page which is working fine

@hkv24
Copy link
Contributor

hkv24 commented Sep 17, 2024

@sambhavgupta0705 look at 'components/NewsletterSubscribe.tsx'

@prashantrai-30
Copy link

Hey,@JeelRajodiya can you assign this to me.

@JeelRajodiya
Copy link
Contributor Author

JeelRajodiya commented Sep 18, 2024 •
edited
Loading

Found it. Here is how you can access the /newsletter page

1. Go to the footer of the website.

2. Click on About

image

3. Now on the about page. you will find a link to the newsletter

image

That's not it. The newsletter page is also linked from multiple blogs

@JeelRajodiya
Copy link
Contributor Author

JeelRajodiya commented Sep 18, 2024 •
edited
Loading

Hey,@JeelRajodiya can you assign this to me.

Issues are not assigned on the website repo (AFAIK). If the issue is valid, you can start working on it and a create PR.

@JeelRajodiya JeelRajodiya mentioned this issue Oct 9, 2024
Closed
2 tasks
@Varun-Kolanu Varun-Kolanu linked a pull request Oct 21, 2024 that will close this issue
Open
@Aryan4884
Copy link

@JeelRajodiya I can still see this issue present on the website.Can i work on this ?

@JeelRajodiya
Copy link
Contributor Author

@JeelRajodiya I can still see this issue present on the website.Can i work on this ?

I think PR #3308 is relevant to this issue and is still under review. You should avoid working on the issues which already have a PR open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
6 participants
@JeelRajodiya @sambhavgupta0705 @jayp5545 @hkv24 @Aryan4884 @prashantrai-30