Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Footer section language not changing when language is changed #3720

Closed
2 tasks done
Recxsmacx opened this issue Feb 22, 2025 · 2 comments
Closed
2 tasks done

[BUG] Footer section language not changing when language is changed #3720

Recxsmacx opened this issue Feb 22, 2025 · 2 comments
Labels

Comments

@Recxsmacx
Copy link

Describe the bug.

When switching languages, the footer section text does not change and remains in the default language.

Expected behavior

The footer section text should change to the selected language.

Screenshots

Image

Image

How to Reproduce

Go to the homepage AsyncAPI
Change the language from English to German
Observe that the footer section text remains in English

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@Recxsmacx Recxsmacx added the bug label Feb 22, 2025
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@Recxsmacx
Copy link
Author

20250222-0708-44.0927940.mp4

#after the possible changes it is looking like this

Recxsmacx added a commit to Recxsmacx/website that referenced this issue Feb 22, 2025
Fixes asyncapi#3720

Add language support to the footer section to address the issue of the footer text not changing when the language is switched.

* **Footer Component (`components/footer/Footer.tsx`)**
  - Import `useTranslation` hook from `next-i18next`.
  - Use `useTranslation` hook to get the `t` function.
  - Replace hardcoded text with `t` function calls for translation.
  - Add `currentLanguage` prop to the `Footer` component.
  - Use `currentLanguage` prop to determine the language for translations.

* **Next-i18next Configuration (`next-i18next.config.js`)**
  - Add `footer` to the `namespaces` array.

* **App Component (`pages/_app.tsx`)**
  - Pass the current language as a prop to the `Footer` component.

* **Translation Files**
  - Add English translations for the footer section in `public/locales/en/footer.json`.
  - Add German translations for the footer section in `public/locales/de/footer.json`.
Recxsmacx added a commit to Recxsmacx/website that referenced this issue Mar 5, 2025
Fixes asyncapi#3720

Add language support to the footer section to address the issue of the footer text not changing when the language is switched.

* **Footer Component (`components/footer/Footer.tsx`)**
  - Import `useTranslation` hook from `next-i18next`.
  - Use `useTranslation` hook to get the `t` function.
  - Replace hardcoded text with `t` function calls for translation.
  - Add `currentLanguage` prop to the `Footer` component.
  - Use `currentLanguage` prop to determine the language for translations.

* **Next-i18next Configuration (`next-i18next.config.js`)**
  - Add `footer` to the `namespaces` array.

* **App Component (`pages/_app.tsx`)**
  - Pass the current language as a prop to the `Footer` component.

* **Translation Files**
  - Add English translations for the footer section in `public/locales/en/footer.json`.
  - Add German translations for the footer section in `public/locales/de/footer.json`.
Recxsmacx added a commit to Recxsmacx/website that referenced this issue Mar 5, 2025
Related to asyncapi#3716

Fixes asyncapi#3720

Add language support to the footer section to address the issue of the footer text not changing when the language is switched.

* **Footer Component (`components/footer/Footer.tsx`)**
  - Import `useTranslation` hook from `next-i18next`.
  - Use `useTranslation` hook to get the `t` function.
  - Replace hardcoded text with `t` function calls for translation.
  - Add `currentLanguage` prop to the `Footer` component.
  - Use `currentLanguage` prop to determine the language for translations.

* **Next-i18next Configuration (`next-i18next.config.js`)**
  - Add `footer` to the `namespaces` array.

* **App Component (`pages/_app.tsx`)**
  - Pass the current language as a prop to the `Footer` component.

* **Translation Files**
  - Add English translations for the footer section in `public/locales/en/footer.json`.
  - Add German translations for the footer section in `public/locales/de/footer.json`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants