Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added 'Welcome' to the mobile view dropdown menu #3738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PRAteek-singHWY
Copy link
Contributor

@PRAteek-singHWY PRAteek-singHWY commented Feb 25, 2025

Description

  1. Fixed the missing "Welcome" item in the mobile dropdown menu.
  2. Ensured all dropdown components display correctly on smaller screens.
  3. Verified UI consistency across different viewports.

Issue Investigation

While debugging with:
" console.log('DocsLayout received post logs:', post); "

I found that instead of "sectionTitle" from the posts.json file, we needed to use "title". The console logs confirmed that the correct data property is "title" which is to be used inside "DocsLayout.tsx"

Console Output showed :

Screenshot 2025-02-25 at 22 19 00 2

Before:-

imageedit_9_4408168945

After:-

imageedit_7_8848497426

Fixes #3724

Summary by CodeRabbit

  • New Features
    • Updated the sidebar toggle button to display the post title instead of the section title, offering clearer navigation for users.

Copy link
Contributor

coderabbitai bot commented Feb 25, 2025

Walkthrough

This pull request updates the DocsLayout component by changing the button label. The button text that previously displayed the post's section title now shows the post's title. The overall structure and functionality of the component remain unchanged.

Changes

File Change Summary
components/layout/DocsLayout.tsx Updated button label from post.sectionTitle to post.title

Suggested labels

ready-to-merge

Suggested reviewers

  • derberg
  • devilkiller-ag
  • akshatnema
  • sambhavgupta0705
  • anshgoyalevil
  • asyncapi-bot-eve
  • Mayaleeeee

Poem

I'm a hopping rabbit in a code-filled glade,
Tweaking button labels in a playful parade.
From section to title, the change is small,
Yet it makes the DocsLayout feel grand to all.
Leaping joyfully, I celebrate this call!
🐰🎉


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89c7f7a and 3383eaf.

📒 Files selected for processing (1)
  • components/layout/DocsLayout.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (4)
  • GitHub Check: Redirect rules - asyncapi-website
  • GitHub Check: Header rules - asyncapi-website
  • GitHub Check: Pages changed - asyncapi-website
  • GitHub Check: Lighthouse CI
🔇 Additional comments (1)
components/layout/DocsLayout.tsx (1)

136-136: Fix looks good - addresses the missing "Welcome" item in mobile view.

Changing from post.sectionTitle to post.title correctly fixes the issue where the "Welcome" item wasn't appearing in the mobile dropdown menu. This change makes the UI consistent with the rest of the component, which already uses post.title in other places (like line 152 for the main heading).

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Feb 25, 2025

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 The subject "Added 'Welcome' to the mobile view  dropdown menu" found in the pull request title "fix: Added 'Welcome' to the mobile view  dropdown menu" should start with a lowercase character.

Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 39fc0fb
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/67bee065d1ce420008d9e44e
😎 Deploy Preview https://deploy-preview-3738--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8b378c9) to head (39fc0fb).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3738   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          732       732           
=========================================
  Hits           732       732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PRAteek-singHWY PRAteek-singHWY changed the title Fix: Added 'Welcome' to the mobile view dropdown menu fix: Added 'Welcome' to the mobile view dropdown menu Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Missing "Welcome" Dropdown in Mobile View
2 participants