fix: Added placeholder links and metadata for missing tool details (#3810) #3869
Conversation
SURAJ-RATHI
requested review from
derberg,
akshatnema,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThis commit updates the configuration in Changes
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
We require all PRs to follow Conventional Commits specification. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3869 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 667 667
Branches 113 113
=========================================
Hits 667 667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
config/tools.json (2)
15-21: Improved Language Filter Metadata for "API Tracker - AsyncAPI specs"
The language filter now includes a JavaScript placeholder object with defined background and border color properties. This update ensures that the tool card doesn’t render blank language metadata in the UI. Please remember that these values are temporary placeholders and should be updated with accurate metadata when available.
110-116: Added Placeholder for Language Filter in "AsyncAPI-Directory by APIs.guru"
The previously empty language filter has now been populated with a JavaScript object featuring placeholder color settings. This change helps maintain a consistent UI by ensuring that each tool card displays valid metadata. Verify that similar updates have been applied wherever the metadata was previously missing.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
config/tools.json(1 hunks)
⏰ Context from checks skipped due to timeout of 180000ms (4)
- GitHub Check: Redirect rules - asyncapi-website
- GitHub Check: Header rules - asyncapi-website
- GitHub Check: Pages changed - asyncapi-website
- GitHub Check: Lighthouse CI
There was a problem hiding this comment.
Hi @SURAJ-RATHI Thank you for your contribution and identifying this, but I don't think this is the right way to fix this inconsistency or issue, hence I am closing this PR.
Plus I don't see @sambhavgupta0705 actually approving the issue referenced, he was still waiting to hear a good fix before assigning it to someone, I'd recommend working with them on the issue and open a relevant PR then :)
Description:
This PR resolves inconsistencies in the Tools section where certain tools were missing essential metadata such as githubUrl, docsUrl, language, and tags.
Since I did not have the exact references, I have used dummy placeholder links as a temporary fix. Maintainers or contributors with knowledge of the correct details should replace them.
Problem:
Some tools had incomplete or false links.
Missing data resulted in cards displaying empty content in the UI.
The inconsistency led to an inconsistent user experience.
Fixes and Changes:
✅ Added placeholder links for githubUrl, docsUrl, tags, and languages.
✅ Ensured all tool cards display without missing content.
✅ Added inline comments in the config/tools.json file indicating that actual data should be updated.
Fix: #3810
How to Test:
Navigate to the Tools section in the deployed preview.
Verify that the previously empty or broken tool cards now contain placeholders.
Ensure maintainers replace dummy data with actual links and metadata.
Screenshot:
Summary by CodeRabbit